Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automatic variable imports in EquationWriter optional. #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

schymans
Copy link
Collaborator

@schymans schymans commented Jun 18, 2021

This enables deactivating automatic inclusion of variable imports by EquationWriter. The default is still to include all variables, but it can be deactivated by passing autovars=0 to EquationWriter.eq and EquationWriter.neweq.

Closes #100.

@schymans schymans requested a review from jirikuncar June 18, 2021 10:18
essm/_generator.py Outdated Show resolved Hide resolved
jirikuncar
jirikuncar previously approved these changes Jul 6, 2021
@schymans
Copy link
Collaborator Author

schymans commented Jul 7, 2021

For some reason, sphinx fails in the travis-ci:

Exception occurred:

  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/nbsphinx.py", line 1813, in apply

    env.get_domain('math').data['has_equations'][env.docname] = True

KeyError: 'has_equations'

The full traceback has been saved in /tmp/sphinx-err-vakrs_zm.log, if you want to report the issue to the developers.

Please also report this if it was a user error, so that a better error message can be provided next time.

A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

The command "python setup.py build_sphinx" exited with 1.

This does not happen locally for me. Any idea what might be wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EquationWriter includes imports of variables, but this can lead to error
2 participants