Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Xcode 10.2 and Swift 5 #71

Merged
merged 5 commits into from
Mar 28, 2019
Merged

Migrate to Xcode 10.2 and Swift 5 #71

merged 5 commits into from
Mar 28, 2019

Conversation

dterzic
Copy link
Contributor

@dterzic dterzic commented Mar 27, 2019

  • Migrated to Xcode 10.2 and Swift 5.
  • Fixed warnings reported by Swift 5.

- Fixed warnings reported by Swift 5.
@GeroHerkenrath
Copy link

Hm, this is surprising, I would have expected travis to complain about return String(cString: UnsafePointer(strerror(errno))), as that throws an error when I try to build Ambassador on it (see envoy/Ambassador#48).

Guess that's because naturally that pipeline still pulls the Swift 4.2 version of the code.


Note that this PR here is already a step further than #70 as the only difference so far seems to be that you also updated the travis configuration, so I am curious where the warnings should be fixed. I'd be willing to contribute (I took a look at the warnings locally already), but I don't wanna open yet another PR. What's the plan for now, if there is any?

@dterzic
Copy link
Contributor Author

dterzic commented Mar 28, 2019

@GeroHerkenrath Yeah, I saw that PR but it had some build errors.
Because we needed Embassy in order to complete the migration of Kiosk I just added another (temporary) branch (didn't even fixed the warnings).
@LFabien What do you think is the best way to proceed?

@LFabien
Copy link

LFabien commented Mar 28, 2019

@dterzic @TomCarey @GeroHerkenrath Thanks for working on that, I'll merge this PR.

@GeroHerkenrath I think this error has been fixed here #66

@LFabien LFabien merged commit faad1ac into master Mar 28, 2019
@LFabien LFabien deleted the swift5 branch March 28, 2019 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants