Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 conversion #70

Closed
wants to merge 2 commits into from
Closed

Swift 5 conversion #70

wants to merge 2 commits into from

Conversation

TomCarey
Copy link

Used Xcode 10.2 (10E125) to convert to Swift 5 automatically.
Applied recommended project changes.

@GeroHerkenrath
Copy link

Hey, @TomCarey!

Thanks for starting this. I began the same task for Ambassador, see envoy/Ambassador#48. It seems I might have found an issue that would also bite your migration should you fix/update the travis config for this PR to run the tests successfully, see https://forums.developer.apple.com/thread/113919.

In short: String(cString: UnsafePointer(strerror(errno))) will most likely have to be changed to just String(cString: strerror(errno))

@TomCarey
Copy link
Author

@GeroHerkenrath No need to have two swift 5 PRs.. I'll close my one.

@TomCarey TomCarey closed this Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants