Skip to content

Commit

Permalink
Fix compile error due to unused lambda capture (#50)
Browse files Browse the repository at this point in the history
This commit fixes the following compilation error:

```
ERROR: /Users/marpaia/git/envoy-filter-example/http-filter-example/BUILD:37:1: C++ compilation of rule '//http-filter-example:http_filter_config' failed (Exit 1)
http-filter-example/http_filter_config.cc:49:14: error: lambda capture 'context' is not used [-Werror,-Wunused-lambda-capture]
    return [&context, config](Http::FilterChainFactoryCallbacks& callbacks) -> void {
             ^
1 error generated.
Target //http-filter-example:envoy failed to build
```

This commit also adds Envoy's `.clang-format` file so that editors don't incorrectly format C++.

Signed-off-by: Mike Arpaia <mike@arpaia.co>
  • Loading branch information
marpaia authored and htuch committed May 7, 2018
1 parent 72a1927 commit cfcdc8a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions .clang-format
@@ -0,0 +1,9 @@
---
Language: Cpp
AccessModifierOffset: -2
ColumnLimit: 100
DerivePointerAlignment: false
PointerAlignment: Left
SortIncludes: false
...

4 changes: 2 additions & 2 deletions http-filter-example/http_filter_config.cc
Expand Up @@ -41,12 +41,12 @@ class HttpSampleDecoderFilterConfig : public NamedHttpFilterConfigFactory {
std::string name() override { return "sample"; }

private:
Http::FilterFactoryCb createFilter(const sample::Decoder& proto_config, FactoryContext& context) {
Http::FilterFactoryCb createFilter(const sample::Decoder& proto_config, FactoryContext&) {
Http::HttpSampleDecoderFilterConfigSharedPtr config =
std::make_shared<Http::HttpSampleDecoderFilterConfig>(
Http::HttpSampleDecoderFilterConfig(proto_config));

return [&context, config](Http::FilterChainFactoryCallbacks& callbacks) -> void {
return [config](Http::FilterChainFactoryCallbacks& callbacks) -> void {
auto filter = new Http::HttpSampleDecoderFilter(config);
callbacks.addStreamDecoderFilter(Http::StreamDecoderFilterSharedPtr{filter});
};
Expand Down

0 comments on commit cfcdc8a

Please sign in to comment.