Skip to content

Commit

Permalink
Update gogo/prototbuf and nghttp2 dependencies (#4761)
Browse files Browse the repository at this point in the history
Update dependencies - gogo/prototbuf 1.1.1 (release notes) & nghttp2 1.34.0 (release notes). nghttp2 update implements Implement RFC 8441 which should enable H2 with websockets

Risk Level: Medium
Testing: bazel test //test/... and running on local instances
Docs Changes: none required
Release Notes: none required

Signed-off-by: Michael Payne <michael@sooper.org>
  • Loading branch information
moderation authored and alyssawilk committed Oct 17, 2018
1 parent 818fc0c commit 38ccd02
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
15 changes: 9 additions & 6 deletions api/bazel/repositories.bzl
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
BAZEL_SKYLIB_RELEASE = "0.5.0"
BAZEL_SKYLIB_SHA = "b5f6abe419da897b7901f90cbab08af958b97a8f3575b0d3dd062ac7ce78541f"
BAZEL_SKYLIB_SHA256 = "b5f6abe419da897b7901f90cbab08af958b97a8f3575b0d3dd062ac7ce78541f"

GOGOPROTO_RELEASE = "1.1.1"
GOGOPROTO_SHA256 = "9f8c2ad49849ab063cd9fef67e77d49606640044227ecf7f3617ea2c92ef147c"

GOOGLEAPIS_SHA = "d642131a6e6582fc226caf9893cb7fe7885b3411" # May 23, 2018
GOGOPROTO_SHA = "1adfc126b41513cc696b209667c8656ea7aac67c" # v1.0.0
PROMETHEUS_SHA = "99fa1f4be8e564e8a6b613da7fa6f46c9edafc6c" # Nov 17, 2017
OPENCENSUS_SHA = "ab82e5fdec8267dc2a726544b10af97675970847" # May 23, 2018

Expand All @@ -13,9 +15,9 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
def api_dependencies():
native.http_archive(
name = "bazel_skylib",
url = "https://github.com/bazelbuild/bazel-skylib/archive/" + BAZEL_SKYLIB_RELEASE + ".tar.gz",
sha256 = BAZEL_SKYLIB_SHA,
sha256 = BAZEL_SKYLIB_SHA256,
strip_prefix = "bazel-skylib-" + BAZEL_SKYLIB_RELEASE,
url = "https://github.com/bazelbuild/bazel-skylib/archive/" + BAZEL_SKYLIB_RELEASE + ".tar.gz",
)
git_repository(
name = "com_lyft_protoc_gen_validate",
Expand Down Expand Up @@ -189,8 +191,9 @@ py_proto_library(

native.new_http_archive(
name = "com_github_gogo_protobuf",
strip_prefix = "protobuf-" + GOGOPROTO_SHA,
url = "https://github.com/gogo/protobuf/archive/" + GOGOPROTO_SHA + ".tar.gz",
sha256 = GOGOPROTO_SHA256,
strip_prefix = "protobuf-" + GOGOPROTO_RELEASE,
url = "https://github.com/gogo/protobuf/archive/v" + GOGOPROTO_RELEASE + ".tar.gz",
build_file_content = """
load("@com_google_protobuf//:protobuf.bzl", "cc_proto_library", "py_proto_library")
load("@io_bazel_rules_go//proto:def.bzl", "go_proto_library")
Expand Down
4 changes: 2 additions & 2 deletions ci/build_container/build_recipes/nghttp2.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

set -e

VERSION=1.33.0
SHA256=42fff7f290100c02234ac3b0095852e4392e6bfd95ebed900ca8bd630850d88c
VERSION=1.34.0
SHA256=8889399ddd38aa0405f6e84f1c050a292286089441686b8a9c5e937de4f5b61d

curl https://github.com/nghttp2/nghttp2/releases/download/v"$VERSION"/nghttp2-"$VERSION".tar.gz -sLo nghttp2-"$VERSION".tar.gz \
&& echo "$SHA256" nghttp2-"$VERSION".tar.gz | sha256sum --check
Expand Down

0 comments on commit 38ccd02

Please sign in to comment.