Skip to content

Commit

Permalink
filter-network-redis: add support for single-key STREAM commands (#35105
Browse files Browse the repository at this point in the history
)

Commit Message:
Add support for all the stream commands which are hashable on their
first argument (the key)

Additional Description:
This is a repeat of #33436 which
I sadly let get stale before following up on responses.

Risk Level: Low

Testing:
Manual, also covered by existing tests

Docs Changes:
Added additional commands in the docs.

Release Notes:
Added to release notes.

Platform Specific Features: N/A

Signed-off-by: Nick Cooper <nick@not.fun>
  • Loading branch information
nicknotfun committed Jul 9, 2024
1 parent 6145b7e commit 3ff644b
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 4 deletions.
3 changes: 3 additions & 0 deletions changelogs/current.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,9 @@ removed_config_or_runtime:
Removed ``envoy.reloadable_features.enable_connect_udp_support`` runtime flag and legacy code paths.
new_features:
- area: redis
change: |
Added support for xack, xadd, xautoclaim, xclaim, xdel, xlen, xpending, xrange, xrevrange, xtrim.
- area: hot_restart
change: |
Added new command-line flag :option:`--skip-hot-restart-parent-stats`.
Expand Down
10 changes: 10 additions & 0 deletions docs/root/intro/arch_overview/other_protocols/redis.rst
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,16 @@ For details on each command's usage see the official
SETNX, String
SETRANGE, String
STRLEN, String
XACK, Stream
XADD, Stream
XAUTOCLAIM, Stream
XCLAIM, Stream
XDEL, Stream
XLEN, Stream
XPENDING, Stream
XRANGE, Stream
XREVRANGE, Stream
XTRIM, Stream

Failure modes
-------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ struct SupportedCommands {
"ltrim", "persist", "pexpire", "pexpireat", "pfadd", "pfcount", "psetex", "pttl", "restore",
"rpop", "rpush", "rpushx", "sadd", "scard", "set", "setbit", "setex", "setnx", "setrange",
"sismember", "smembers", "spop", "srandmember", "srem", "sscan", "strlen", "ttl", "type",
"watch", "zadd", "zcard", "zcount", "zincrby", "zlexcount", "zpopmin", "zpopmax", "zrange",
"zrangebylex", "zrangebyscore", "zrank", "zrem", "zremrangebylex", "zremrangebyrank",
"zremrangebyscore", "zrevrange", "zrevrangebylex", "zrevrangebyscore", "zrevrank", "zscan",
"zscore");
"watch", "xack", "xadd", "xautoclaim", "xclaim", "xdel", "xlen", "xpending", "xrange",
"xrevrange", "xtrim", "zadd", "zcard", "zcount", "zincrby", "zlexcount", "zpopmin",
"zpopmax", "zrange", "zrangebylex", "zrangebyscore", "zrank", "zrem", "zremrangebylex",
"zremrangebyrank", "zremrangebyscore", "zrevrange", "zrevrangebylex", "zrevrangebyscore",
"zrevrank", "zscan", "zscore");
}

/**
Expand Down

0 comments on commit 3ff644b

Please sign in to comment.