Comment explaining string-view by reference

Signed-off-by: Raven Black <ravenblack@dropbox.com>
envoyproxy · May 10, 2024 · 57b9055 · 57b9055
1 parent 7ece7eb
commit 57b9055
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/source/common/common/compiled_string_map.h b/source/common/common/compiled_string_map.h
@@ -49,6 +49,9 @@ namespace Envoy {
  * for the string node.
  */
 template <class Value> class CompiledStringMap {
+  // While it is usual to take a string_view by value, in this
+  // performance-critical context with repeatedly passing the same
+  // value, passing it by reference benchmarks out slightly faster.
   using FindFn = std::function<Value(const absl::string_view&)>;
 
 public: