fixing asan

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
envoyproxy · May 23, 2024 · 8ef48c6 · 8ef48c6
1 parent 2cb30b3
commit 8ef48c6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/test/extensions/tracers/dynamic_ot/config_test.cc b/test/extensions/tracers/dynamic_ot/config_test.cc
@@ -22,6 +22,8 @@ namespace Tracers {
 namespace DynamicOt {
 namespace {
 
+// TODO(https://github.com/envoyproxy/envoy/issues/34321)
+#if !__has_feature(address_sanitizer)
 TEST(DynamicOtTracerConfigTest, DEPRECATED_FEATURE_TEST(DynamicOpentracingHttpTracer)) {
   NiceMock<Server::Configuration::MockTracerFactoryContext> context;
   EXPECT_CALL(context.server_factory_context_.cluster_manager_,
@@ -52,6 +54,7 @@ TEST(DynamicOtTracerConfigTest, DEPRECATED_FEATURE_TEST(DynamicOpentracingHttpTr
   auto tracer = factory.createTracerDriver(*message, context);
   EXPECT_NE(nullptr, tracer);
 }
+#endif
 
 } // namespace
 } // namespace DynamicOt

diff --git a/test/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl_test.cc b/test/extensions/tracers/dynamic_ot/dynamic_opentracing_driver_impl_test.cc
@@ -55,6 +55,8 @@ TEST_F(DynamicOpenTracingDriverTest, FormatErrorMessage) {
             DynamicOpenTracingDriver::formatErrorMessage(error_code, "abc"));
 }
 
+// TODO(https://github.com/envoyproxy/envoy/issues/34321)
+#if !__has_feature(address_sanitizer)
 TEST_F(DynamicOpenTracingDriverTest, InitializeDriver) {
   {
     std::string invalid_library = "abc123";
@@ -71,6 +73,7 @@ TEST_F(DynamicOpenTracingDriverTest, InitializeDriver) {
     EXPECT_THROW(setup(library_path_, empty_config), EnvoyException);
   }
 }
+#endif
 
 // This test fails under gcc, please see https://github.com/envoyproxy/envoy/issues/7647
 // for more details.