-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoadStatsIntegrationTest flake #11784
Comments
also 2020-07-01T18:50:30.2092982Z [ RUN ] IpVersionsClientType/LoadStatsIntegrationTest.InProgress/0 |
The issue is:
@alyssawilk @antoniovicente I don't think I'm going to have time to fix this before I take off for vacation. This might be the cause of similar coverage flakes. cc @lizan @jmarantz |
Opened #11860 to track why it's so hard to debug failures on coverage. |
If it's a timeout it could be that the response is timing out, or that some other infinite wait is causing us to not get to the point where the upstream operates (one more reason I like autonomous upstream). |
Replacing an infinite timeout in load stats test with a "fast" fail of 5s. Risk Level: n/a Testing: test passes Ideally gets debug info for #11784 Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes #11784 Signed-off-by: Matt Klein <mklein@lyft.com>
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes #11784 Signed-off-by: Matt Klein <mklein@lyft.com>
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes envoyproxy#11784 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes envoyproxy#11784 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yuchen Dai <silentdai@gmail.com> Co-authored-by: Matt Klein <mklein@lyft.com>
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes envoyproxy#11784 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes envoyproxy#11784 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
The text was updated successfully, but these errors were encountered: