[release-1.7] load stats: fix integration test flake (#12265) #245
Conversation
Waiting on a load stats response can race with resetting the counters when initializing a watch. Moving the counter increment prevents the race. Fixes envoyproxy#11784 Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Yuchen Dai <silentdai@gmail.com>
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
/retest |
|
|
|
/retest |
1 similar comment
|
/retest |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Waiting on a load stats response can race with resetting
the counters when initializing a watch. Moving the counter
increment prevents the race.
Fixes envoyproxy#11784
Signed-off-by: Matt Klein mklein@lyft.com
Signed-off-by: Yuchen Dai silentdai@gmail.com