Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API v2 HeaderValueOption append flag is ignored #2003

Closed
zuercher opened this issue Nov 6, 2017 · 1 comment
Closed

API v2 HeaderValueOption append flag is ignored #2003

zuercher opened this issue Nov 6, 2017 · 1 comment
Assignees
@zuercher
Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions.

Comments

@zuercher
Copy link
Member

zuercher commented Nov 6, 2017

API v2 HeaderValueOption is used for modifying request and response headers in the RouteConfiguration, VirtualHosts, and RouteAction messages. The v2 documentation indicates that the default behavior is to replace headers with the given value. In practice, Envoy appends values to existing headers and the replace behavior cannot be enabled.

HeaderValueOption definition
@zuercher zuercher mentioned this issue Nov 6, 2017
Closed
@mattklein123 mattklein123 added beginner Good starter issues! enhancement Feature requests. Not bugs or questions. help wanted Needs help! labels Nov 7, 2017
@zuercher
Copy link
Member Author

zuercher commented Nov 7, 2017

I started working on this one, since I want this behavior for #2002.

@mattklein123 mattklein123 removed the help wanted Needs help! label Nov 7, 2017
zuercher added a commit to turbinelabs/envoy that referenced this issue Nov 8, 2017
@zuercher
router: implement append/override of request/response headers to add (f…
6684ab4 
…ixes envoyproxy#2003)

Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
This was referenced Nov 8, 2017
Merged
Merged
htuch pushed a commit to envoyproxy/data-plane-api that referenced this issue Nov 9, 2017
@zuercher @htuch
RDS: add response_headers_to_add/remove fields in VirtualHost and Rou…
9f7557b 
…teAction (#229)

Provides API support for envoyproxy/envoy#2002 and fixes comment related to envoyproxy/envoy#2003.

Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
mattklein123 pushed a commit that referenced this issue Nov 15, 2017
@zuercher @mattklein123
router: implement append/override of request/response headers to add (f…
9f7f8f5 
…ixes #2003) (#2025)

Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
@lizan @istio-testing
alts: remove ALTS (envoyproxy#2003)
426eea9 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
@lizan
alts: remove ALTS (envoyproxy#2003)
26f5fc5 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
@rshriram
Merge master into release-1.1 (envoyproxy#2031)
4d8eb98 
* Improve performance by removing MD5 for check cache keys (envoyproxy#2002)

* Improve performance by removing MD5 for check cache keys

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* not to allocate memory from stack

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Make debug string readable

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* alts: remove ALTS (envoyproxy#2003)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* Use std::hash for check cache. (envoyproxy#2009)

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Remove tests to compare signature values (envoyproxy#2015)

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* update sample envoy config to latest version (envoyproxy#2016)

* Add a new TCP cluster rewrite filter (envoyproxy#2017)

* Add a new TCP cluster rewrite filter

This commit adds a new TCP cluster rewrite filter which allows users to
rewrite TCP cluster names obtained via TLS SNI by matching via regex
configuration.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Make TCP cluster rewrite stackable on SNI filter

This commit updates the TCP Cluster Rewrite filter to be stackable on
the SNI Cluster filter.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Update TCP Cluster Rewrite filter name (envoyproxy#2019)

This commit updates the TCP Cluster Rewrite filter name to
envoy.filters.network.tcp_cluster_rewrite.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Enable TCP Cluster Rewrite filter registration (envoyproxy#2021)

This commit enables the static registration of the TCP Cluster Rewrite
filter by updating the build configuration.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Update Envoy SHA to 4ef8562 (envoyproxy#2023)

Envoy /server_info API was inconsistent intermittently causing errors on
a Proxy update on Istio. This update will bring in the API fix to Istio.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* add proxy postsubmit periodic (envoyproxy#2025)
Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
@JimmyCYJ @istio-testing
Merge master to release-1.1 (envoyproxy#2038)
9b91ac6 
* Improve performance by removing MD5 for check cache keys (envoyproxy#2002)

* Improve performance by removing MD5 for check cache keys

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* not to allocate memory from stack

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Make debug string readable

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* alts: remove ALTS (envoyproxy#2003)

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* Use std::hash for check cache. (envoyproxy#2009)

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* Remove tests to compare signature values (envoyproxy#2015)

Signed-off-by: Wayne Zhang <qiwzhang@google.com>

* update sample envoy config to latest version (envoyproxy#2016)

* Add a new TCP cluster rewrite filter (envoyproxy#2017)

* Add a new TCP cluster rewrite filter

This commit adds a new TCP cluster rewrite filter which allows users to
rewrite TCP cluster names obtained via TLS SNI by matching via regex
configuration.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Make TCP cluster rewrite stackable on SNI filter

This commit updates the TCP Cluster Rewrite filter to be stackable on
the SNI Cluster filter.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Update TCP Cluster Rewrite filter name (envoyproxy#2019)

This commit updates the TCP Cluster Rewrite filter name to
envoy.filters.network.tcp_cluster_rewrite.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Enable TCP Cluster Rewrite filter registration (envoyproxy#2021)

This commit enables the static registration of the TCP Cluster Rewrite
filter by updating the build configuration.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* Update Envoy SHA to 4ef8562 (envoyproxy#2023)

Envoy /server_info API was inconsistent intermittently causing errors on
a Proxy update on Istio. This update will bring in the API fix to Istio.

Signed-off-by: Venil Noronha <veniln@vmware.com>

* add proxy postsubmit periodic (envoyproxy#2025)

* Update Envoy SHA to c41fa71 (envoyproxy#2029)

* Update Envoy SHA

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* Fix format.

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* bazel: Allow to distdir all dependencies (envoyproxy#2034)

To use --distdir option of Bazel (which allows to use previously
fetched tarballs instead of downloading dependencies during
build), all dependencies should use http instead of git and need
to have sha256 sums specified.

Signed-off-by: Michal Rostecki <mrostecki@suse.de>

* bazel: Remove BoringSSL repository (envoyproxy#2035)

Pull request envoyproxy#2002 removed signature calculation which was using
BoringSSL as a dependency. BoringSSL is not needed anymore.

Signed-off-by: Michal Rostecki <mrostecki@suse.de>

* Update Envoy SHA to fcc68f1 (envoyproxy#2037)

* Update Envoy SHA to fcc68f1

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>

* Update SHA256

Signed-off-by: JimmyCYJ <jimmychen.0102@gmail.com>
@esmet esmet mentioned this issue Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuercher zuercher

Labels
beginner Good starter issues! enhancement Feature requests. Not bugs or questions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuercher @mattklein123