-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with OpenCensus stats collection and distributed tracing framework #2456
Comments
@PiotrSikora I believe that OpenCensus trace driver support is already being started. I don't see us deleting the other trace providers (at least in the near term) but would love to provide this as an option. |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions. |
I'm curious about the interest levels in this as well. Because OpenCensus defines the context propagation format, it seems like getting Envoy to play with that will be critical for anyone who wants to use OpenCensus for tracing |
@bogdandrutu can you provide the latest thinking here FTR. |
As a potential smaller step supporting the OpenCensus binary trace context propagation format in the existing Zipkin tracer would be useful in deployments using a Zipkin-compatible tracing backend |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions. |
Marking help wanted. This should be a straightforward change to add a new OC trace driver. |
See additional information and history re: OpenCensus in Envoy at envoyproxy/data-plane-api#345 (comment). It would be good to fix the current non-functioning TraceService code or remove it if the implementation or plans change. |
@g-easy can you please take care of this? |
I have a prototype of an OpenCensus trace driver, I'll roll a PR soon. |
Part of #2456 Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
As per the update, the OpenCensus trace driver is in #5387. Please take a look. :) |
Part of envoyproxy#2456 Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Addresses #2456 Risk level: Low Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
I think this is done! |
* add hash policy for mixer Signed-off-by: Kuat Yessenov <kuat@google.com> * fix test Signed-off-by: Kuat Yessenov <kuat@google.com> * name the workspace Signed-off-by: Kuat Yessenov <kuat@google.com> * update upstream Signed-off-by: Kuat Yessenov <kuat@google.com> * fix tests Signed-off-by: Kuat Yessenov <kuat@google.com>
Description: Disable interface binding in Android Kotlin example app as we have no clear plans for enabling interface binding anytime soon and having it disabled makes debugging of the example app (and Envoy Mobile) easier. On top of that, the same feature is not enabled in iOS example apps. Risk Level: None, example app change only. Testing: Example app run manually. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Signed-off-by: JP Simard <jp@jpsim.com>
Description: Disable interface binding in Android Kotlin example app as we have no clear plans for enabling interface binding anytime soon and having it disabled makes debugging of the example app (and Envoy Mobile) easier. On top of that, the same feature is not enabled in iOS example apps. Risk Level: None, example app change only. Testing: Example app run manually. Docs Changes: N/A Release Notes: N/A Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com Signed-off-by: JP Simard <jp@jpsim.com>
Google just released OpenCensus, which is (emphasis mine):
This could potentially be a replacement for all the custom tracing frameworks we support in Envoy.
cc @mattklein123 @alyssawilk @htuch
The text was updated successfully, but these errors were encountered: