Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with OpenCensus stats collection and distributed tracing framework #2456

Closed
PiotrSikora opened this issue Jan 25, 2018 · 13 comments
Closed
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Milestone

Comments

@PiotrSikora
Copy link
Contributor

Google just released OpenCensus, which is (emphasis mine):

A single distribution of libraries that automatically collects traces and metrics from your app, displays them locally, and sends them to any analysis tool.

The key features of OpenCensus include:

  1. Standard wire protocols and consistent APIs for handling trace and metric data.
  2. A single set of libraries for many languages, including Java, C++, Go, .Net, Python, PHP, Node.js, Erlang, and Ruby.
  3. Included integrations with web and RPC frameworks, making traces and metrics available out of the box.
  4. Included exporters for storage and analysis tools. Right now the list includes Zipkin, Prometheus, Jeager, Stackdriver, and SignalFx.
  5. Full open source availability for additional integrations and export options.
  6. No additional server or daemon is required to support OpenCensus.
  7. In process debugging: an optional agent for displaying request and metrics data on instrumented hosts.

This could potentially be a replacement for all the custom tracing frameworks we support in Envoy.

cc @mattklein123 @alyssawilk @htuch

@mattklein123 mattklein123 added the enhancement Feature requests. Not bugs or questions. label Jan 25, 2018
@mattklein123
Copy link
Member

@PiotrSikora I believe that OpenCensus trace driver support is already being started. I don't see us deleting the other trace providers (at least in the near term) but would love to provide this as an option.

@stale
Copy link

stale bot commented Jun 20, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 20, 2018
@stale
Copy link

stale bot commented Jun 27, 2018

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Jun 27, 2018
@mpuncel
Copy link
Contributor

mpuncel commented Aug 30, 2018

I'm curious about the interest levels in this as well. Because OpenCensus defines the context propagation format, it seems like getting Envoy to play with that will be critical for anyone who wants to use OpenCensus for tracing

@htuch
Copy link
Member

htuch commented Aug 30, 2018

@bogdandrutu can you provide the latest thinking here FTR.

@htuch htuch reopened this Aug 30, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Aug 30, 2018
@mpuncel
Copy link
Contributor

mpuncel commented Aug 31, 2018

As a potential smaller step supporting the OpenCensus binary trace context propagation format in the existing Zipkin tracer would be useful in deployments using a Zipkin-compatible tracing backend

@stale
Copy link

stale bot commented Sep 30, 2018

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Sep 30, 2018
@mattklein123 mattklein123 added the help wanted Needs help! label Sep 30, 2018
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Sep 30, 2018
@mattklein123
Copy link
Member

Marking help wanted. This should be a straightforward change to add a new OC trace driver.

@moderation
Copy link
Contributor

moderation commented Sep 30, 2018

See additional information and history re: OpenCensus in Envoy at envoyproxy/data-plane-api#345 (comment). It would be good to fix the current non-functioning TraceService code or remove it if the implementation or plans change.

@bogdandrutu
Copy link

@g-easy can you please take care of this?

@g-easy
Copy link
Contributor

g-easy commented Dec 13, 2018

I have a prototype of an OpenCensus trace driver, I'll roll a PR soon.

htuch pushed a commit that referenced this issue Dec 19, 2018
Part of #2456

Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
@g-easy
Copy link
Contributor

g-easy commented Dec 21, 2018

As per the update, the OpenCensus trace driver is in #5387. Please take a look. :)

fredlas pushed a commit to fredlas/envoy that referenced this issue Mar 5, 2019
Part of envoyproxy#2456

Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
@mattklein123 mattklein123 added this to the 1.11.0 milestone May 2, 2019
htuch pushed a commit that referenced this issue Jun 5, 2019
Addresses #2456

Risk level: Low

Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
@mattklein123
Copy link
Member

I think this is done!

Shikugawa pushed a commit to Shikugawa/envoy that referenced this issue Mar 28, 2020
* add hash policy for mixer

Signed-off-by: Kuat Yessenov <kuat@google.com>

* fix test

Signed-off-by: Kuat Yessenov <kuat@google.com>

* name the workspace

Signed-off-by: Kuat Yessenov <kuat@google.com>

* update upstream

Signed-off-by: Kuat Yessenov <kuat@google.com>

* fix tests

Signed-off-by: Kuat Yessenov <kuat@google.com>
jpsim pushed a commit that referenced this issue Nov 28, 2022
Description: Disable interface binding in Android Kotlin example app as we have no clear plans for enabling interface binding anytime soon and having it disabled makes debugging of the example app (and Envoy Mobile) easier. On top of that, the same feature is not enabled in iOS example apps.
Risk Level: None, example app change only.
Testing: Example app run manually.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this issue Nov 29, 2022
Description: Disable interface binding in Android Kotlin example app as we have no clear plans for enabling interface binding anytime soon and having it disabled makes debugging of the example app (and Envoy Mobile) easier. On top of that, the same feature is not enabled in iOS example apps.
Risk Level: None, example app change only.
Testing: Example app run manually.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Development

No branches or pull requests

7 participants