Update opencensus-proto dependency to v0.1.0 release. #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
census-instrumentation/opencensus-proto#61 changed to the fully qualified and this broke protoc-gen-validate: I don't know enough about go_package or protoc-gen-validate; could someone please help me: what's the way forward here? cc @rakyll |
|
Looks like you're hitting bufbuild/protoc-gen-validate#41 (per @htuch's research) |
|
@akonradi @rodaine any thoughts on how best to tackle bufbuild/protoc-gen-validate#41? |
|
Similar to the override presented here for the Java path, something similar should be done for C++ (otherwise, it'll follow the protoc-gen-go rules): https://github.com/lyft/protoc-gen-validate/blob/a346734/templates/pkg.go#L34 |
|
@rodaine I'll give this a go this arvo. |
Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com>
htuch
approved these changes
Dec 19, 2018
|
Thanks for the PGV fix! I'm not authorized to merge this pull request. |
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Part of envoyproxy#2456 Signed-off-by: Emil Mikulic <g-easy@users.noreply.github.com> Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Emil Mikulic g-easy@users.noreply.github.com
Part of #2456