Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate gRPC Starlark changes to keep Envoy working with Bazel 1.0 #7863

Closed
lberki opened this issue Aug 8, 2019 · 1 comment
Closed

Integrate gRPC Starlark changes to keep Envoy working with Bazel 1.0 #7863

lberki opened this issue Aug 8, 2019 · 1 comment
Labels
area/build no stalebot Disables stalebot from closing an issue
Milestone
1.12.0

Comments

@lberki
Copy link
Contributor

lberki commented Aug 8, 2019 •
edited
Loading

Bazel 1.0 will remove the legacy .proto. provider to access information about protocol buffers and only allow[ProtoInfo].

These got fixed in gRPC in ecf04ccf4d8be9378166ec9e0ccf44081e211d11 and 49f0fb9035120d0f5b5fa49846324c0b2d59c257, but gRPC needs to be updated in Envoy so that they take effect.

In the meantime, I sent out grpc/grpc#19860 as a workaround.

Note that this issue has a sister issue #7835, which deals with a slightly changed directory layout in 0.29 (however, that one is breakage in Bazel 0.29 and this one is breakage in Bazel 1.0)
@lberki lberki mentioned this issue Aug 8, 2019
Merged
@lizan lizan added area/build no stalebot Disables stalebot from closing an issue labels Aug 8, 2019
@mattklein123 mattklein123 added this to the 1.12.0 milestone Aug 11, 2019
@mattklein123
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build no stalebot Disables stalebot from closing an issue
Projects
None yet
Milestone
1.12.0
Development

No branches or pull requests
3 participants
@lizan @lberki @mattklein123