-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C++ code generation to work with Bazel 0.29 . #19860
Conversation
The above Bazel version changes proto compilation slightly: some proto files are put into a `_virtual_imports` directory and thus `_get_include_directory` needs to be updated accordingly. Ideally, it would use instead the `ProtoInfo` provider to tease out the proto import directories, but that's a bit more intrusive change.
This is to fix bazelbuild/bazel#9032 . It should be benign, since previous Bazel versions did not use the |
Glad to see bazelbuild/bazel#7157 is getting taken care of. Thanks for the PR! |
Existing failures:
Still need a review from a codeowner. @jtattermusch @nicolasnoble ? |
@gnossen , do I understand correctly that the above breakages are also at HEAD and thus okay? |
It's my job to take care of these things! Unfortunately, this time, the collateral damage was greater than zero but it also made the way |
@lberki Yes. The failures I listed above are known flakes or deterministic failures on master that should be unrelated to the changes in this PR and should not block merging. |
(friendly ping) Note that this is breaking Envoy and google-cloud-cpp, so it would be real nice if this got fixed. |
(friendly ping) |
Thanks! What's the process for merging this? (I don't have a bit fat green "Merge" button...) |
Thanks! Now on for propagating this downstream (but that's my problem!) |
The above Bazel version changes proto compilation slightly: some proto
files are put into a
_virtual_imports
directory and thus_get_include_directory
needs to be updated accordingly.Ideally, it would use instead the
ProtoInfo
provider to tease out theproto import directories, but that's a bit more intrusive change.