Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC change needs to be integrated so that Envoy keeps working with Bazel 0.29 #7835

Closed
lberki opened this issue Aug 6, 2019 · 5 comments
Closed

Comments

@lberki
Copy link
Contributor

lberki commented Aug 6, 2019

Bazel 0.29 reshuffled protocol buffers slightly and it broke gRPC which tried to guess what Bazel does. The Bazel bug is here:

bazelbuild/bazel#9032

The pull request to gRPC to fix it:

grpc/grpc#19860

however, it'll need to be integrated into Envoy so that Envoy keeps working.

@mattklein123
Copy link
Member

cc @keith @lizan

@mattklein123 mattklein123 added this to the 1.12.0 milestone Aug 6, 2019
@keith
Copy link
Member

keith commented Aug 6, 2019

I'd be happy to update once that change merges. Is there going to be a release with it? (I assume no)

@lberki
Copy link
Contributor Author

lberki commented Aug 6, 2019

Dunno... ask the gRPC folks.

@lizan
Copy link
Member

lizan commented Aug 6, 2019

OK, at least we have a patch when we upgrade our Bazel. We're already in bazelisk so there are less chance to break CI widely when updating build image.

@mattklein123
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants