api: freeze of v2 API, cut v4alpha API. #10672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch performs a major version freeze and bump by modifying package_version_status, using the tooling developed in envoyproxy#10636. Specifically: * v2 APIs are frozen (except for where they are the latest in their package history and still active) * v3 APIs are transitioned to be active * Candidate v4alpha APIs are generated (not used by Envoy yet) Fixes envoyproxy#10355 Risk level: medium (entire API's files are modified, visually verified to ensure things look sane, all tests pass) Testing: CI Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
previously approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Nice, awesome work.
Per offline convo, this PR will not yield any user error if someone accidentally modifies the v2 API. The changes just won't forward propagate. @htuch and I agreed that we can snap 1.14.0 with this PR, but we should do a fast follow to have a CI check that makes sure that moving forward the only changes to v2 protos are comment/doc changes, and no actual API changes. This is mostly to avoid developer confusion. Thank you!
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Apr 7, 2020
lizan
approved these changes
Apr 7, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch performs a major version freeze and bump by modifying
package_version_status, using the tooling developed in #10636.
Specifically:
package history and still active)
Fixes #10355
Risk level: medium (entire API's files are modified, visually verified
to ensure things look sane, all tests pass)
Testing: CI
Signed-off-by: Harvey Tuch htuch@google.com