Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: various changes #118

Merged
merged 2 commits into from
Oct 5, 2016
Merged

perf: various changes #118

merged 2 commits into from
Oct 5, 2016

Conversation

mattklein123
Copy link
Member

  1. Don't use fmt::format() in HTTP/1.1 codec hot path
  2. Allow x-request-id generation to be disabled
  3. Don't do tracing mutation if tracing is not enabled
  4. Allow router dynamic stats to be disabled
  5. Don't generate useless random numbers for null runtime

mattklein123 and others added 2 commits October 4, 2016 17:06
@mattklein123
perf: various changes
452003f 
1) Don't use fmt::format() in HTTP/1.1 codec hot path
2) Allow x-request-id generation to be disabled
3) Don't do tracing mutation if tracing is not enabled
3) Allow router dynamic stats to be disabled
4) Don't generate useless random numbers for null runtime
@mattklein123
Update router_filter.rst
7bdf302
@mattklein123
Copy link
Member Author

@lyft/network-team

RomanDzhabarov
RomanDzhabarov reviewed Oct 5, 2016
View reviewed changes
source/common/http/http1/codec_impl.cc
output_buffer_.add(method);
output_buffer_.add(" ");
output_buffer_.add(path);
output_buffer_.add(" HTTP/1.1\r\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use CRLF as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another function call for no particular reason

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sound good

RomanDzhabarov
RomanDzhabarov approved these changes Oct 5, 2016
View reviewed changes
Copy link
Member

@RomanDzhabarov RomanDzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattklein123 mattklein123 merged commit 6591604 into master Oct 5, 2016
@mattklein123 mattklein123 deleted the perf_testing branch October 5, 2016 17:31
venilnoronha pushed a commit to venilnoronha/envoy that referenced this pull request Nov 8, 2019
@lambdai @rlenglet
listener: clean up accept filters before connection creation (envoypr…
de61162 
…oxy#118)

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
lizan pushed a commit that referenced this pull request Mar 3, 2020
@PiotrSikora @lizan
tls_inspector: enable TLSv1.3. (#118)
4a15932 
Previously, TLS inspector didn't support TLSv1.3 and clients configured
to use only TLSv1.3 were not recognized as TLS clients.

Because TLS extensions (SNI, ALPN) were not inspected, those connections
might have been matched to a wrong filter chain, possibly bypassing some
security restrictions in the process.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
lizan pushed a commit that referenced this pull request Mar 3, 2020
@PiotrSikora @lizan
tls_inspector: enable TLSv1.3. (#118)
1b0f2a1 
Previously, TLS inspector didn't support TLSv1.3 and clients configured
to use only TLSv1.3 were not recognized as TLS clients.

Because TLS extensions (SNI, ALPN) were not inspected, those connections
might have been matched to a wrong filter chain, possibly bypassing some
security restrictions in the process.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit to PiotrSikora/envoy that referenced this pull request Mar 3, 2020
@PiotrSikora
tls_inspector: enable TLSv1.3. (envoyproxy#118)
97e7660 
Previously, TLS inspector didn't support TLSv1.3 and clients configured
to use only TLSv1.3 were not recognized as TLS clients.

Because TLS extensions (SNI, ALPN) were not inspected, those connections
might have been matched to a wrong filter chain, possibly bypassing some
security restrictions in the process.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit to PiotrSikora/envoy that referenced this pull request Mar 3, 2020
@PiotrSikora
tls_inspector: enable TLSv1.3. (envoyproxy#118) (envoyproxy#173)
1af8b4e 
Previously, TLS inspector didn't support TLSv1.3 and clients configured
to use only TLSv1.3 were not recognized as TLS clients.

Because TLS extensions (SNI, ALPN) were not inspected, those connections
might have been matched to a wrong filter chain, possibly bypassing some
security restrictions in the process.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@fscz fscz mentioned this pull request Apr 16, 2020
Closed
shalk pushed a commit to shalk/envoy that referenced this pull request Nov 14, 2020
@majinghe
Merge pull request envoyproxy#118 from scilla0531/zh_trans_advanced
ac9b1d8 
zh-translation: docs/root/intro/arch_overview/advanced/advanced.rst
arminabf pushed a commit to arminabf/envoy that referenced this pull request Jun 5, 2024
@M4tteoP @anuraaga
updates crs, coaraza, go-ftw, tests (envoyproxy#118)
551c04a 
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanDzhabarov RomanDzhabarov RomanDzhabarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattklein123 @RomanDzhabarov