Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: added fuzz test for listener filter original_dst #11847

Merged
merged 15 commits into from
Jul 8, 2020

Conversation

arthuryan-k
Copy link
Contributor

Signed-off-by: Arthur Yan arthuryan@google.com

Commit Message: Added fuzz test for listener filter original_dst
Additional Description:

Created original_dst_corpus and populated with testcases (different protocol schemes)
Created original_dst_fuzz_test.cc and original_dst_fuzz_test.proto, updated BUILD

Risk Level: Low
Testing: ran fuzzer, increased function and line coverage of original_dst.cc to 100%. fuzzer routes correctly through getOriginalDst() and addressFromSockAddr(), covers all valid cases / lines.
Docs Changes: N/A
Release Notes: N/A

/cc @akonradi
/cc @asraa

Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
@asraa asraa assigned asraa and akonradi and unassigned asraa Jul 1, 2020
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nice! Love how easy to understand this is. I have a few minor questions.

Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Signed-off-by: Arthur Yan <arthuryan@google.com>
Copy link
Contributor

@akonradi akonradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arthur! Excited to ship this and iterate on more fuzzers :)

(and particularly excited about re-using the super speedy socket!)

@asraa asraa merged commit 673cab8 into envoyproxy:master Jul 8, 2020
@arthuryan-k arthuryan-k deleted the fuzz_original_dst branch July 8, 2020 15:07
jwendell pushed a commit to istio/envoy that referenced this pull request Jul 21, 2020
* Revert "test: shard http2_integration_test (envoyproxy#11939)"

This reverts commit 2026ec2.

* Revert "fuzz: added fuzz test for listener filter original_dst (envoyproxy#11847)"

This reverts commit 673cab8.

* Revert "docs: updating release instructions (envoyproxy#11938)"

This reverts commit 09b96a5.

* Revert "test: remove superfluous test dependencies (envoyproxy#11912)"

This reverts commit 5e9fb8a.

* Revert "dynamic_forward_proxy: cleanup integration test (envoyproxy#11891)"

This reverts commit 11a4667.

* Revert "preliminary PR to Porting Envoy to C++17 (envoyproxy#11840)"

This reverts commit 9ad964d.

* Revert "connection: Do not reset delayed closed timer if doWrite consumes 0 bytes from the output buffer. (envoyproxy#11833)"

This reverts commit 5960533.

* Revert "threadlocal: avoiding a dynamic cast in opt builds (envoyproxy#11900)"

This reverts commit 363b104.

* Revert "release: kicking off 1.16.0 (envoyproxy#11930)"

This reverts commit ef74d8f.

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
)

Commit Message: Added fuzz test for listener filter original_dst
Created original_dst_corpus and populated with testcases (different protocol schemes)
Created original_dst_fuzz_test.cc and original_dst_fuzz_test.proto, updated BUILD

increased function and line coverage of original_dst.cc to 100%. fuzzer routes correctly through getOriginalDst() and addressFromSockAddr(), covers all valid cases / lines.
Signed-off-by: Arthur Yan <arthuryan@google.com>

Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants