Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp: switching to the new pool by default #12180

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

alyssawilk
Copy link
Contributor

Risk Level: High (roll back first, ask questions later)
Testing: cloned all unit tests and all integration tests.
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.new_tcp_connection_pool

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if anyone's run Envoy in prod with the flag turned on?

@alyssawilk
Copy link
Contributor Author

Not that I know of, but I defaulted it off because of proximity to the release rather than smoke testing.

@zuercher zuercher self-assigned this Jul 20, 2020
@alyssawilk alyssawilk merged commit f50fba1 into envoyproxy:master Jul 20, 2020
ggreenway added a commit to ggreenway/envoy that referenced this pull request Jul 20, 2020
This reverts commit f50fba1.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
mattklein123 pushed a commit that referenced this pull request Jul 21, 2020
This reverts commit f50fba1.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
Risk Level: High (roll back first, ask questions later)
Testing: cloned all unit tests and all integration tests.
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.new_tcp_connection_pool

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
…y#12192)

This reverts commit f50fba1.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
Risk Level: High (roll back first, ask questions later)
Testing: cloned all unit tests and all integration tests.
Docs Changes: n/a
Release Notes: inline
Runtime guard: envoy.reloadable_features.new_tcp_connection_pool

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
…y#12192)

This reverts commit f50fba1.

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants