-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: implement getMonotonicTimeNanoseconds. #16352
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@PiotrSikora PTAL! (I will merge the corresponding PR once you approve.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, but I think it's fine to merge the PR in Proxy-Wasm C++ Host.
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
could you take a look on deps? @moderation Thank you! |
/lgtm deps |
Supports clock_time_get in WASI with monotonic clock_id. Ref: proxy-wasm/proxy-wasm-cpp-host#156 and proxy-wasm/proxy-wasm-rust-sdk#103
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
will mark this as ready for review once the test passes and the corresponding PR in cpp-host has landed master.