Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: implement getMonotonicTimeNanoseconds. #16352

Merged
merged 4 commits into from
May 7, 2021

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented May 6, 2021

Supports clock_time_get in WASI with monotonic clock_id. Ref: proxy-wasm/proxy-wasm-cpp-host#156 and proxy-wasm/proxy-wasm-rust-sdk#103
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

will mark this as ready for review once the test passes and the corresponding PR in cpp-host has landed master.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16352 was opened by mathetake.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 6, 2021
@mathetake
Copy link
Member Author

@PiotrSikora PTAL! (I will merge the corresponding PR once you approve.)

PiotrSikora
PiotrSikora previously approved these changes May 6, 2021
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, but I think it's fine to merge the PR in Proxy-Wasm C++ Host.

test/extensions/common/wasm/test_data/test_cpp.cc Outdated Show resolved Hide resolved
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake marked this pull request as ready for review May 6, 2021 07:52
@mathetake mathetake requested a review from lizan as a code owner May 6, 2021 07:52
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mathetake
Copy link
Member Author

could you take a look on deps? @moderation Thank you!

@moderation
Copy link
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 7, 2021
@lizan lizan merged commit 8d934d1 into envoyproxy:main May 7, 2021
@mathetake mathetake deleted the wasm-monotonic-time branch May 9, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants