proto: add a new field called append_action in the HeaderValueOption #18246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
| // Header name/value pair that this option applies to. | ||
| HeaderValue header = 1 [(validate.rules).message = {required: true}]; | ||
|
|
||
| // Should the value be appended? If true (default), the value is appended to | ||
| // existing values. Otherwise it replaces any existing values. | ||
| google.protobuf.BoolValue append = 2; | ||
|
|
||
| // Describes the action taken to append/overwrite the given value for an existing header | ||
| // or to only add this header if it's absent. Value defaults to :ref:`APPEND_IF_EXISTS_OR_ADD<envoy_v3_api_enum_value_config.core.v3.HeaderValueOption.HeaderAppendAction.APPEND_IF_EXISTS_OR_ADD>`. |
There was a problem hiding this comment.
Can you mark this [#not-implemented-hide] just in case it takes a bit for the other PR to land? Thank you.
/wait
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
approved these changes
Sep 24, 2021
Thanks, @mattklein123! Yes, I'll revert the not-implemented hide changes and will address all the remaining comments. |
soulxu
pushed a commit
to soulxu/envoy
that referenced
this pull request
Oct 16, 2021
…nvoyproxy#18246) Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field called
append_actionto theHeaderValueOption. This is just the.protochange being done in the preparation for #18130. We'll mark the existingappendfield as deprecated in #18310.append_actionextends the header matcher by describing what append action to take indicating whether:Commit Message: add a new field called append_action in the HeaderValueOption.
Additional Description: Adds a new field called
append_actioninHeaderValueOptionwhich will ultimately deprecate the oldappendand will extend the existing matcher functionality.Risk Level: -
Testing: -
Docs Changes: N/A (Will be done in #18130)
Release Notes: N/A (Will be done in #18130)
Platform Specific Features: N/A
Signed-off-by: Rohit Agrawal rohit.agrawal@databricks.com