route: implementation of HeaderAppendAction #22723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
htuch
reviewed
Aug 17, 2022
soulxu
requested changes
Aug 17, 2022
htuch
reviewed
Aug 18, 2022
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
wbpcode
changed the title
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
wbpcode
requested review from
ggreenway,
mattklein123 and
snowp
as code owners
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
htuch
reviewed
Aug 25, 2022
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
This reverts commit b8e6967.
|
Because some special behavior in the |
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
htuch
reviewed
Aug 26, 2022
| @@ -55,7 +54,7 @@ HeaderFormatterPtr parseInternal(const envoy::config::core::v3::HeaderValue& hea | |||
|
|
|||
| absl::string_view format(header_value.value()); | |||
| if (format.empty()) { | |||
| return std::make_unique<PlainHeaderFormatter>("", append); | |||
There was a problem hiding this comment.
For my education, why did we ever have append here?
There was a problem hiding this comment.
I see actually, you now propagate this independent of the header formatter, seems cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: route: implementation of HeaderAppendAction
Additional Description:
The HeaderAppendAction was added in the #18246. But the implementation never done. This PR try to complete this feature.
Further work of #18246. To close #22713.
Risk Level: Low.
Testing: Unit Test.
Docs Changes: n/a.
Release Notes: wait.
Platform Specific Features: n/a