New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updating Codeowners #20512
docs: updating Codeowners #20512
Conversation
cc @envoyproxy/envoy-maintainers can folks call out "owned" extensions you'd be Ok owning? |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton for working on this. I'm just flushing out some initial thoughts.
CODEOWNERS
Outdated
/*/extensions/network/dns_resolver/cares @yanavlasov @UNOWNED | ||
/*/extensions/network/dns_resolver/apple @yanavlasov @UNOWNED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can take these.
CODEOWNERS
Outdated
/*/extensions/filters/common/ext_authz @esmet @gsagula @UNOWNED | ||
/*/extensions/filters/http/ext_authz @esmet @gsagula @UNOWNED | ||
/*/extensions/filters/network/ext_authz @esmet @gsagula @UNOWNED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to own this personally, but calling out this is critical and we need an owner. I will work on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add @pradeepcrao to the owner list for ext_authz
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Ok, I think I addressed all of the comments (but if you commented, PTAL and make sure I didn't mix things up) |
CODEOWNERS
Outdated
/*/extensions/tracers/zipkin @UNOWNED @UNOWNED | ||
/*/extensions/tracers/dynamic_ot @UNOWNED @UNOWNED | ||
/*/extensions/tracers/opencensus @UNOWNED @UNOWNED | ||
/*/extensions/tracers/common @UNOWNED @UNOWNED | ||
/*/extensions/tracers/common/ot @UNOWNED @UNOWNED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracing in general needs better ownership. Perhaps @lizan and @Shikugawa ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracing system is ok for me. I had some relatively large PRs before about tracing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also can help with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can try to help with the tracers. If we have the option can I get zipkin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also help on tracers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @basvanbeek! Can you open a PR to add yourself?
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
LGTM. And tracing system is ok for me. You can add me to the owner list. And cc @Shikugawa also can helps. And cc @suniltheta is interested in zipkin. Thanks. 😄
|
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for my rgs1, thanks!
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Nit: @unowned seems to be a real account. Perhaps creating a team under @envoyproxy would make more sense than giving the codeowners rights to a stranger? |
changing this file doesn't affect permissions, and I don't think it can cc them on reviews as they're not in org. |
CODEOWNERS
Outdated
# IP tagging | ||
/*/extensions/filters/http/ip_tagging @rgs1 @UNOWNED | ||
# mongo proxy | ||
/*/extensions/filters/network/mongo_proxy @mythra @giantcroc @UNOWNED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do stamps on this after @Mythra and @giantcroc since I wrote the original code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG. I'll take ip tagging and formatting since @rgs1 has been so helpful to the comunity, and @daixiang0 had offered to help in general so I'll tag him as the second for cors, and we're good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, I'd like to help with VCL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, I'd like to help with VCL (/contrib/vcl/), thanks
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Oops needs main merge. /wait |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay
Fixing the tooling to pull the current maintainers list Moving all extensions into CODEOWNERS.md and finding owners for all extensions. go, go Envoy community! Risk Level: n/a (docs / tooling) Testing: fix format checks Docs Changes: yes Release Notes: n/a Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Fixing the tooling to pull the current maintainers list
Moving all extensions into CODEOWNERS.md and finding owners for all extensions.
go, go Envoy community!
Risk Level: n/a (docs / tooling)
Testing: fix format checks
Docs Changes: yes
Release Notes: n/a