Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v1.19] ci: Fix broken tests #20753

Merged
merged 6 commits into from
Apr 13, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 9, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:

  • partial fix for macOS (VM)
  • fix for windows VM
  • fix cache verify example
  • fix VRP verify example

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
lizan
lizan previously approved these changes Apr 11, 2022
@lizan
Copy link
Member

lizan commented Apr 11, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #20753 (comment) was created by @lizan.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Apr 11, 2022

@mattklein123 this one and #20754 fix most of the current problems with the v1.18/v1.19 branches' CI and are probably worth landing past the current failures

they dont fix the mac issue entirely - altho apparently for different reasons

@ggreenway would you be able to have a look at the macos CI failures

@phlax phlax changed the title [backport/v1.19] ci: Pin windows VM version [backport/v1.19] ci: Fix broken tests Apr 11, 2022
Matt Klein and others added 2 commits April 13, 2022 14:17
This should give very basic sanity coverage.

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax merged commit 846d840 into envoyproxy:release/v1.19 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants