Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v1.18] ci: Fix broken tests #20754

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 9, 2022

Commit Message:

  • partial fix for macOS (VM)
  • fix for windows VM
  • fix cache verify example
  • fix VRP verify example

Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax changed the title [backport/v1.18] Pin macOS VM version [backport/v1.18] ci: Pin macOS VM version Apr 9, 2022
@phlax phlax changed the title [backport/v1.18] ci: Pin macOS VM version [WIP/backport/v1.18] ci: Pin macOS VM version Apr 9, 2022
@phlax phlax marked this pull request as draft April 9, 2022 19:24
@phlax
Copy link
Member Author

phlax commented Apr 9, 2022

macos is still failing - not sure where logs go

================================================================================
FAIL: //test/integration:tcp_tunneling_integration_test (see /private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/integration/tcp_tunneling_integration_test/test.log)

FAILED: //test/integration:tcp_tunneling_integration_test (Summary)
      /private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/integration/tcp_tunneling_integration_test/test.log
      /private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/integration/tcp_tunneling_integration_test/test_attempts/attempt_1.log

- partial fix for macOS (VM)
- fix for windows VM
- fix cache verify example
- fix VRP verify example

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP/backport/v1.18] ci: Pin macOS VM version [backport/v1.18] ci: Fix broken tests Apr 10, 2022
@phlax phlax marked this pull request as ready for review April 10, 2022 19:38
@zuercher
Copy link
Member

If you search for the failed test name the output is further up in the logs (have to use CI's search box, not the browser's):

[ RUN      ] IpAndHttpVersions/TcpTunnelingIntegrationTest.UpstreamConnectingDownstreamDisconnect/IPv4_HTTP2Upstream_WaitConnectResponse
test/integration/tcp_tunneling_integration_test.cc:623: Failure
Value of: upstream_request_->waitForReset()
  Actual: false (Timed out waiting for reset.)
Expected: true
Stack trace:
  0x10950c4c0: Envoy::(anonymous namespace)::TcpTunnelingIntegrationTest_UpstreamConnectingDownstreamDisconnect_Test::TestBody()
  0x11460dc84: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
  0x1145e37bb: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x1145e36f3: testing::Test::Run()
  0x1145e46c7: testing::TestInfo::Run()
... Google Test internal frames ...
[ RUN      ] IpAndHttpVersions/TcpTunnelingIntegrationTest.UpstreamConnectingDownstreamDisconnect/IPv6_HTTP2Upstream_WaitConnectResponse
test/integration/tcp_tunneling_integration_test.cc:623: Failure
Value of: upstream_request_->waitForReset()
  Actual: false (Timed out waiting for reset.)
Expected: true
Stack trace:
  0x10950c4c0: Envoy::(anonymous namespace)::TcpTunnelingIntegrationTest_UpstreamConnectingDownstreamDisconnect_Test::TestBody()
  0x11460dc84: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
  0x1145e37bb: testing::internal::HandleExceptionsInMethodIfSupported<>()
  0x1145e36f3: testing::Test::Run()
  0x1145e46c7: testing::TestInfo::Run()
... Google Test internal frames ...

@phlax
Copy link
Member Author

phlax commented Apr 12, 2022

any clues on the cause/fix @zuercher ?

ci/docker_ci.sh Outdated Show resolved Hide resolved
This should give very basic sanity coverage.

Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax marked this pull request as draft April 13, 2022 12:48
@phlax
Copy link
Member Author

phlax commented Apr 13, 2022

making this WIP while i try and figure the mac failure

@phlax
Copy link
Member Author

phlax commented Apr 13, 2022

great, that fixed it - ill tidy up the PR and unWIP

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax marked this pull request as ready for review April 13, 2022 13:16
@phlax phlax merged commit 59e83f5 into envoyproxy:release/v1.18 Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants