-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport/v1.18] ci: Fix broken tests #20754
Merged
phlax
merged 3 commits into
envoyproxy:release/v1.18
from
phlax:backport-v1.18-pin-macos
Apr 13, 2022
Merged
[backport/v1.18] ci: Fix broken tests #20754
phlax
merged 3 commits into
envoyproxy:release/v1.18
from
phlax:backport-v1.18-pin-macos
Apr 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macos is still failing - not sure where logs go ================================================================================
FAIL: //test/integration:tcp_tunneling_integration_test (see /private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/integration/tcp_tunneling_integration_test/test.log)
FAILED: //test/integration:tcp_tunneling_integration_test (Summary)
/private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/integration/tcp_tunneling_integration_test/test.log
/private/var/tmp/_bazel_runner/3d1a7f52fd47fc9a8db71770aacd13e5/execroot/envoy/bazel-out/darwin-fastbuild/testlogs/test/integration/tcp_tunneling_integration_test/test_attempts/attempt_1.log
|
- partial fix for macOS (VM) - fix for windows VM - fix cache verify example - fix VRP verify example Signed-off-by: Ryan Northey <ryan@synca.io>
6ccf84a
to
b92bb00
Compare
If you search for the failed test name the output is further up in the logs (have to use CI's search box, not the browser's):
|
any clues on the cause/fix @zuercher ? |
phlax
commented
Apr 13, 2022
This should give very basic sanity coverage. Signed-off-by: Matt Klein <mklein@lyft.com> Signed-off-by: Ryan Northey <ryan@synca.io>
making this WIP while i try and figure the mac failure |
great, that fixed it - ill tidy up the PR and unWIP |
Signed-off-by: Ryan Northey <ryan@synca.io>
236b3cd
to
0f2cdce
Compare
zuercher
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]