Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: Add OpenTelemetry tracing #22988

Merged
merged 24 commits into from
Sep 27, 2022
Merged

Example: Add OpenTelemetry tracing #22988

merged 24 commits into from
Sep 27, 2022

Conversation

nguyenptk
Copy link
Member

Signed-off-by: Nguyen Phan nguyenptk@gmail.com

Commit Message: Add OpenTelemetry tracing example
Additional Description:
Risk Level: Low
Testing: README.md guideline
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Nguyen Phan Tran Khoi added 2 commits September 5, 2022 22:55
Example: Add OpenTelemetry tracing
5ae67c3 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
Correct PORT_COLLECTOR_ZPAGE port
55a764c 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
@nguyenptk nguyenptk marked this pull request as draft September 5, 2022 16:15
@phlax phlax self-assigned this Sep 7, 2022
@phlax
Copy link
Member

phlax commented Sep 7, 2022

cc @AlexanderEllis

Nguyen Phan Tran Khoi added 2 commits September 7, 2022 21:26
Fix lints
b3b8159 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
Correct opentelemetry_collector & add http2
acf39e6 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
@nguyenptk
Copy link
Member Author

hi @AlexanderEllis, I'm not sure whether the otel-collector-config.yaml file here has the right configuration? I cannot find any metrics on http://localhost:55679/debug/tracez 🤔

Nguyen Phan Tran Khoi added 2 commits September 7, 2022 21:53
Whitelist otel-collector-config.yaml
1d0d9ce 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
Correct cluster's address
3834be1 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
@nguyenptk
Copy link
Member Author

nguyenptk commented Sep 7, 2022 •
edited
Loading

hi @AlexanderEllis, I'm not sure whether the otel-collector-config.yaml file here has the right configuration? I cannot find any metrics on http://localhost:55679/debug/tracez 🤔

Sorry, my bad, I've corrected the address of clusters. It works now.

http://localhost:55679/debug/tracez?zspanname=opentelemetry.proto.collector.trace.v1.TraceService%2fExport&ztype=1&zlatencybucket=0

I think we just need to correct the document and some verify steps
cc @phlax

Screen Shot 2022-09-07 at 22 11 59

Add healthcheck for otel collector
56a8d2a 
Signed-off-by: Nguyen  Phan Tran Khoi <nguyen.phan@grabtaxi.com>
@phlax
Copy link
Member

phlax commented Sep 16, 2022

I think we just need to correct the document and some verify steps

yep - im currently working on the skywalking sandbox and its evolving a bit from the zipkin one

@nguyenptk
Correct health check & traces verifying
a582393 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Rename opentelemetry and correct verify steps
91a2eda 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@phlax
Copy link
Member

phlax commented Sep 16, 2022

/docs

@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22988/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22988 (comment) was created by @phlax.

see: more, trace.

@nguyenptk
Update docs
451a5cf 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Correct docs
1486f9f 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Correct syntax
137d91c 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Copy link
Member Author

/docs

@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22988/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22988 (comment) was created by @nguyenptk.

see: more, trace.

@nguyenptk
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22988 (comment) was created by @nguyenptk.

see: more, trace.

@nguyenptk
Replace healthcheck CMD to CMD-SHELL
27089e1 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Increase healthcheck timeout and retries
8d78462 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
chmod +x otel-collector-config.yaml
892c9a3 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Test timeout
77b92d0 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22988 (comment) was created by @nguyenptk.

see: more, trace.

@nguyenptk
Move COPY ./otel-collector-config.yaml to Dockerfile
57ad1b4 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Update otel-collector-config.yaml to ./otel-collector-config.yaml
5f1ed7a 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Adjust healtcheck configuration and chmod o+r
160277a 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Correct docker-compose ps information & drop opentelemetry-ui.png
38ce3a9 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
phlax
phlax previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! thanks for adding this @nguyenptk

cc @AlexanderEllis

@nguyenptk
Pin alpine:3.13 image
3fc38bd 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
phlax
phlax previously approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again @nguyenptk

@nguyenptk nguyenptk marked this pull request as ready for review September 26, 2022 12:38
@nguyenptk
Remove x-b3-traceid header
bcf22fc 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Copy link
Member Author

/docs

@repokitteh-read-only
Copy link

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22988/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22988 (comment) was created by @nguyenptk.

see: more, trace.

@AlexanderEllis
Copy link
Contributor

Thanks @nguyenptk, looks great! Excited to see this in place :)

phlax
phlax reviewed Sep 26, 2022
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some last minute nits inline

examples/opentelemetry/envoy-1.yaml Outdated Show resolved Hide resolved
examples/opentelemetry/docker-compose.yaml Outdated Show resolved Hide resolved
docs/root/start/sandboxes/opentelemetry.rst Outdated Show resolved Hide resolved
examples/opentelemetry/envoy-front-proxy.yaml Outdated Show resolved Hide resolved
@nguyenptk
Clean up internal ports in docker-compose
c0d19a5 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
@nguyenptk
Update PORT_COLLECTOR_ZPAGE -> PORT_UI
55b2bb0 
Signed-off-by: nguyenptk <nguyenptk@gmail.com>
phlax
phlax approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant, thanks again!

@phlax phlax merged commit 92eddb4 into envoyproxy:main Sep 27, 2022
@phlax phlax mentioned this pull request Sep 28, 2022
Closed
@AlexanderEllis AlexanderEllis mentioned this pull request Sep 29, 2022
Open
@nguyenptk nguyenptk deleted the otlp-example branch October 1, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nguyenptk @phlax @AlexanderEllis