-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add pipeline change detection #24221
Conversation
aa62874
to
289f752
Compare
hah I was about to ask if it was easier for you to pick this up than suggest all the fixes. Thanks so much for tackling it! LMK when this is ready as I'd love to get something in this week |
99bdff5
to
5ce1ea9
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
5ce1ea9
to
1ad2c76
Compare
i have not added any actual exclusions to this PR - just the framework for detecting changes - as when we add any exclusions we need to think carefully about how it will run on im inclined to not exclude anything when a PR lands - this does risk PRs passing and then failing when they land - but i would rather that than commits passing and then releases not passing and i think we need to ensure every change is tested somewhere |
testing PR is #24204 |
this is probably gtg altho we may need to iterate - testing is hard because the PR introduces change itself |
I'd be inclined to land with at least one CI we think is affected (i.e. https://github.com/envoyproxy/envoy/pull/24204/files) as I'm not sure landing this as-is is going to tell us anything. WDYT? |
adding a change here is probably not going to help as the PR contains change itself i think land this and then run the test PR a couple of times, and then clarify what should/not be excluded |
hmm, actually thinking about it - yep i see - we need at least one thing to be excluded to test - ill add ... |
yeah I'll also say now we have this (or almost) I am so excited to say not run all the Envoy tests for docs only changes. This is going to be pretty awesome :-D |
Signed-off-by: Ryan Northey <ryan@synca.io>
k - ive added a condition which hopefully will only run
should work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see how it goes :-)
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
part of #23758