Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Envoy mobile code into the Envoy repo #23758

Closed
alyssawilk opened this issue Oct 31, 2022 · 8 comments
Closed

Merge Envoy mobile code into the Envoy repo #23758

alyssawilk opened this issue Oct 31, 2022 · 8 comments
Assignees
@alyssawilk
Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@alyssawilk
Copy link
Contributor

alyssawilk commented Oct 31, 2022 •
edited
Loading

Almost all files are copied from envoy-mobile repo to envoy/mobile Source of truth for mobile changes is still envoy-mobile. @alyssawilk is doing updates until we flip source of truth to envoy/mobile.

TODO:

  • run relevant Envoy workflows when dependencies are bumped (phlax)

Thursday(ish) switch source of truth from envoy-mobile to envoy/mobile

  • copy over PRs which have landed since then
  • notify on various slack channels / notify on PRs in flight

Post-move

  • fix up / move github release cron jobs
  • Circleci functionality (e.g. docs) mobile: add CircleCI docs generation CI job #24295
  • Update references to envoyproxy/envoy-mobile repo in source code and docs (Tackle after Thursday)
  • Archive envoyproxy/envoy-mobile repo (Tackle after release workflows moved over)
@alyssawilk alyssawilk added the enhancement Feature requests. Not bugs or questions. label Oct 31, 2022
@alyssawilk alyssawilk self-assigned this Oct 31, 2022
This was referenced Oct 31, 2022
Merged
Merged
alyssawilk added a commit that referenced this issue Nov 2, 2022
@alyssawilk
mobile: starting the repo merge with the assertion filter (#23761)
f5b42d7 
This PR sets up the directory structure, visibility rules, codeowners, adds E-M C++ tests to Envoy CI, and moves one extension over as a proof of concept.

Risk Level: low
Testing: ported test to Envoy CI. did not turn up platform CI yet
Release Notes: inline
Part of #23758

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk added a commit to envoyproxy/envoy-mobile that referenced this issue Nov 2, 2022
@alyssawilk
build: revert boring patch (#2651)
dbdb100 
Reverting #470 which is a patch to boringssl
https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Part of envoyproxy/envoy#23758
Fixes #471

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This was referenced Nov 17, 2022
Closed
Merged
alyssawilk added a commit that referenced this issue Nov 21, 2022
@alyssawilk
Repo merge clean diffs (#24104)
64555aa 
Full repo merge.

Push one:
copied the entire envoy mobile repo into Envoy as is from d1350ec9a42077267c7b19348f49d4da5502d191
copied EM workflows into the Envoy workflow directory

Push 2:
change mobile/envoy to a symlink to the ../ envoy repo instead
add a few files missed in push 1
several file fixups to pass lint (upstreamed in PR envoyproxy/envoy-mobile#2684)
removing proto and absl patches from E-M
edited EM workflows to run from the mobile directory and only run iff mobile/** paths changed (see diffs between first and second PR)
-- disabling swift lint because I can't get it to work.
-- disabling perf because it can't work on first check in (compares to clean head)
-- release validation because it's having OS issues

Risk Level: added EM CI
Testing: new EM tests
Docs Changes: n/a
Release Notes: none
most of #23758

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Contributor Author

perf turned up in (#24153)

@alyssawilk
Copy link
Contributor Author

@jpsim @Augustyniak I think we're at a point we should flip source of truth to the Envoy repo, and do a weekly copy into the E-M repo until we fix up tagging and releases. I've snagged some time on JP's calendar to talk about it next week on the assumption he'll find a time that works and invite whoever is relevant on the Lyft side.

@alyssawilk alyssawilk mentioned this issue Nov 24, 2022
Merged
@jpsim
Copy link
Contributor

jpsim commented Nov 28, 2022

Some other migration tasks that come to mind:

@Augustyniak
Copy link
Contributor

Related fix: #24228

@alyssawilk alyssawilk mentioned this issue Nov 28, 2022
Merged
@RyanTheOptimist RyanTheOptimist mentioned this issue Nov 28, 2022
Merged
@alyssawilk alyssawilk mentioned this issue Nov 28, 2022
Merged
RyanTheOptimist added a commit that referenced this issue Nov 28, 2022
@RyanTheOptimist
Ignore *.s?? intead of *.sw* to make sure git does not ignore .swift (#…
c785075 
…24231)

Ignore *.s?? instead of .sw to make sure git does not ignore .swift files

Part of #23758

Signed-off-by: Ryan Hamilton rch@google.com
@alyssawilk alyssawilk mentioned this issue Nov 29, 2022
Merged
@jpsim jpsim mentioned this issue Nov 29, 2022
Merged
jpsim pushed a commit that referenced this issue Nov 29, 2022
@alyssawilk @jpsim
build: revert boring patch (#2651)
f5c4c1f 
Reverting #470 which is a patch to boringssl
https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

Part of #23758
Fixes #471

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: JP Simard <jp@jpsim.com>
alyssawilk added a commit that referenced this issue Nov 29, 2022
@alyssawilk
process: adding mobile maintainers as reviewers to mobile PRs (#24232)
f379eb5 
Part of #23758

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk mentioned this issue Nov 29, 2022
Merged
alyssawilk added a commit that referenced this issue Nov 30, 2022
@alyssawilk
workflows: copying envoy mobile command workflow (#24251)
ac817e4 
Allow retest for E-M workflows

Part of #23758 workaround until we have #24156

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk mentioned this issue Dec 1, 2022
Merged
alyssawilk pushed a commit that referenced this issue Dec 1, 2022
@jpsim
mobile: add CircleCI docs generation CI job (#24295)
937818c 
This is the CI job that's responsible for building the public website docs at https://envoymobile.io.

Commit Message: mobile: add CircleCI docs generation CI job
Additional Description: This is the CI job that's responsible for building the public website docs at https://envoymobile.io.
Risk Level: Low
Testing: In Envoy Mobile repo.
Docs Changes: Yes :)
Release Notes: None.
Platform Specific Features: Only relevant to mobile.

Part of #23758
Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim
Copy link
Contributor

jpsim commented Dec 8, 2022

run relevant Envoy workflows when dependencies are bumped (phlax)

Done in #24407

@jpsim
Copy link
Contributor

jpsim commented Dec 8, 2022

fix up / move github release cron jobs

This still needs to be done. We discussed this at last week's Envoy Mobile community call, but didn't come to a clear conclusion.

Archive envoyproxy/envoy-mobile repo (Tackle after release workflows moved over)

This was mostly done, GH Actions were disabled, a note was added to the readme saying the repo is archived.

I haven't gone and fully marked the repo as archive using GitHub's tools because that would also lock down issues, and we're still using those for the time being.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 8, 2023
@jpsim
Copy link
Contributor

jpsim commented Jan 13, 2023

Let's close this. We can open new tickets if/when we want to fully archive the previous envoy-mobile repo or re-introduce deploy CI jobs.

@jpsim jpsim closed this as completed Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alyssawilk alyssawilk

Labels
enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpsim @Augustyniak @alyssawilk