github/ci: Dont trigger command workflow for bots #27272
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
| github.event.issue.pull_request | ||
| && github.repository == 'envoyproxy/envoy' | ||
| && github.actor != 'repokitteh-read-only[bot]' | ||
| && github.actor != 'dependabot[bot]' |
There was a problem hiding this comment.
i think these conditions should work correctly - but not 100% - would be good to exclude all bots
There was a problem hiding this comment.
because AND is use here, so seems this new condition is more strict?
There was a problem hiding this comment.
yep - prs only, ~no bots
|
for ref its reducing the footprint here https://github.com/envoyproxy/envoy/actions/workflows/commands.yml there is already some contention (wait to see how long before this comment pops up ... argh - it was quick - the bots heard me) im starting to move some jobs out of azp - partly to reduce contention there and partly because that is the plan (cf #27294 ) so the more we can prevent waste on the machines the better |
|
relatedly this probably would be better to do with rk cc @itayd |
|
@wbpcode im gonna push this through - the ci passed but is messed up here not sure why - i think unrelated i do want to test this on postsubmit tho - so will watch/fix etc now |
|
my first question is what happens on closed prs /retest |
|
Retrying Azure Pipelines: |
|
i think both triggered - altho only rk posted here - probably we want to add the pr state to the condition |
|
hmm - this didnt work exactly - its probably made it faster - it only skips the job now but still sets itself up |
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]