Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ci: Disable syncing to data-plane-api #27665

Closed
wants to merge 1 commit into from

Conversation

phlax
Copy link
Member

@phlax phlax commented May 28, 2023

I am currently shifting the sync jobs -> github actions, and switching the ci from push -> trigger + pull

In the case of data-plane-api there has been some discussion about removing, and its currently unmaintained/borken so may be better to just stop syncing (and triggering useless failing ci)

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title ci: Disable syncing to data-plane-api [WIP] ci: Disable syncing to data-plane-api May 29, 2023
@phlax phlax marked this pull request as draft May 29, 2023 15:09
@phlax
Copy link
Member Author

phlax commented May 29, 2023

lets switch the sync first #27294

@htuch
Copy link
Member

htuch commented Jun 2, 2023

I don't feel that strongly here. If we do want to remove data-plane-api sync, I think let's announce this in the community forum, open an issue, and actually remove data-plane-api content when we do it (rather than leaving it up in a stale state, which seems dangerous if someone is relying on it).

@phlax
Copy link
Member Author

phlax commented Jun 2, 2023

sgtm re plan, the one thing i would raise is that the CI is currently pretty broken - i had a very quick go at fixing it but didnt want to spend more time on it

probably we should disable it for now

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 3, 2023
@github-actions
Copy link

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants