Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.25] test: fix flaky test DownstreamProtocolIntegrationTest.HandleDownstreamSocketFail (#27546) #28013

Closed
wants to merge 1 commit into from

Commits on Jun 16, 2023

  1. test: fix flaky test DownstreamProtocolIntegrationTest.HandleDownstre…

    …amSocketFail (envoyproxy#27546)
    
    The test manually introduces EBADF error on the connection between Envoy and the test client. However, the IoHandleMatcher doesn't distinguish UDP socket from TCP. If the upstream HTTP/3 connection gets the same port number as downstream TCP connection, the EBADF error will be applied to the wrong connection.
    
    Enforce IoHandleMatcher to match socket type.
    
    Risk Level: low, test only
    Testing: existing tests
    Docs Changes: N/A
    Release Notes: N/A
    Partially Fix envoyproxy#27490
    
    Signed-off-by: Dan Zhang <danzh@google.com>
    
    Signed-off-by: danzh <danzh2010@users.noreply.github.com>
    
    Signed-off-by: Ryan Northey <ryan@synca.io>
    danzh2010 authored and phlax committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    3603d5a View commit details
    Browse the repository at this point in the history