Improve the minimal configuration of vpp (#26085) #29022
Conversation
Signed-off-by: YanLongDai <dyl_wlc@163.com>
|
Hi @YanLongDai, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
There was a problem hiding this comment.
lgtm, thanks @YanLongDai
one thing i spotted while reviewing is that pygments has support for vcl code highlighting, we should follow up to set .. code-block::vcl
…nvoyproxy#29022)" This reverts commit c50f885. Signed-off-by: Ryan Northey <ryan@synca.io>
I can do this, but I don't quite understand what the 'vcl' code includes? |
|
thanks @YanLongDai - i tried already in #29066 but it seems there is not actually support - the |
Commit Message: Improve the documentation on the minimum configuration of vpp
Additional Description: The vpp minimization configuration given on the official website does not enable the session layer, which will cause envoy to fail to register with vpp when it is started in vcl mode, because the session layer of vpp is disabled by default, although vpp can also enable session enbale through cli, but for People who do not have a deep understanding of vpp are prone to encounter some pitfalls, so improve the minimum configuration document of vpp
Risk Level: low
Testing:
Docs Changes: yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #26085 ]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]