Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: upgrade dependencies to 3.5.1 #29854

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

adamkotwasinski
Copy link
Contributor

Commit Message: kafka: upgrade dependencies to 3.5.1
Additional Description: cherry-pick of #28932 for envoy v1.24 (other commits were related to mesh-filter, but don't want to backport a whole feature)
Risk Level: Low
Testing: integration testing with full stack; manual testing with adamkotwasinski/envoy-kafka-tests#9
Docs Changes: version numbers
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #29854 was opened by adamkotwasinski.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 28, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #29854 was opened by adamkotwasinski.

see: more, trace.

@adamkotwasinski
Copy link
Contributor Author

/retest

2 similar comments
@adamkotwasinski
Copy link
Contributor Author

/retest

@adamkotwasinski
Copy link
Contributor Author

/retest

@adamkotwasinski
Copy link
Contributor Author

aaaaaAaaaaAAAAAAaaaaaAAAA
/retest

@adamkotwasinski
Copy link
Contributor Author

just a bit more....
/retest

@phlax
Copy link
Member

phlax commented Sep 29, 2023

this branch is pretty flakey unfortunately

@adamkotwasinski
Copy link
Contributor Author

/retest

@phlax
Copy link
Member

phlax commented Sep 29, 2023

@adamkotwasinski it seems like this increases diskspace - probs it was already at the threshold of what is available

we have a hack to workaround this - but im also wondering whether we just dont worry - this branch is set to EOL in a couple of weeks

@adamkotwasinski
Copy link
Contributor Author

Yeah I guess that's some terrible flakiness and in the end we passed both for main and 1.25 and the changes are not meaningful in any shape - the protocol code would have failed originally, the tests generated would have had the same structure (as Kafka datattypes do not change between 3.4 -> 3.5) so there shouldn't have been any issues.
Especially given it's a tsan build and I don't do anything fancy threading in the changed part :D

@adamkotwasinski adamkotwasinski marked this pull request as ready for review September 29, 2023 19:43
@adamkotwasinski
Copy link
Contributor Author

/assign @phlax

@phlax
Copy link
Member

phlax commented Sep 29, 2023

i think it really just is running out of diskspace - the vms for these branches/tests are already at the brink

if we want to land it i can point to some similar code we can add to remove some cruft

@adamkotwasinski adamkotwasinski marked this pull request as draft September 30, 2023 01:15
@phlax
Copy link
Member

phlax commented Oct 2, 2023

we are hitting the diskspace issue elsewhere so ive raised a PR to fix the problem #29900

@adamkotwasinski
Copy link
Contributor Author

I saw some changes being merged so why not try again :)
/retest

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good, lgtm, thanks @adamkotwasinski

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 3, 2023
@adamkotwasinski adamkotwasinski marked this pull request as ready for review October 3, 2023 20:57
@phlax phlax merged commit 3c12866 into envoyproxy:release/v1.24 Oct 3, 2023
32 checks passed
@adamkotwasinski adamkotwasinski deleted the port-kafka-to-124 branch October 3, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants