-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kafka: upgrade dependencies to 3.5.1 #29854
kafka: upgrade dependencies to 3.5.1 #29854
Conversation
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
/retest |
2 similar comments
/retest |
/retest |
aaaaaAaaaaAAAAAAaaaaaAAAA |
just a bit more.... |
this branch is pretty flakey unfortunately |
/retest |
@adamkotwasinski it seems like this increases diskspace - probs it was already at the threshold of what is available we have a hack to workaround this - but im also wondering whether we just dont worry - this branch is set to EOL in a couple of weeks |
Yeah I guess that's some terrible flakiness and in the end we passed both for main and 1.25 and the changes are not meaningful in any shape - the protocol code would have failed originally, the tests generated would have had the same structure (as Kafka datattypes do not change between 3.4 -> 3.5) so there shouldn't have been any issues. |
/assign @phlax |
i think it really just is running out of diskspace - the vms for these branches/tests are already at the brink if we want to land it i can point to some similar code we can add to remove some cruft |
we are hitting the diskspace issue elsewhere so ive raised a PR to fix the problem #29900 |
I saw some changes being merged so why not try again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be good, lgtm, thanks @adamkotwasinski
Commit Message: kafka: upgrade dependencies to 3.5.1
Additional Description: cherry-pick of #28932 for envoy v1.24 (other commits were related to mesh-filter, but don't want to backport a whole feature)
Risk Level: Low
Testing: integration testing with full stack; manual testing with adamkotwasinski/envoy-kafka-tests#9
Docs Changes: version numbers
Release Notes: n/a
Platform Specific Features: n/a