Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: upgrade dependencies to 3.5.1 #28932

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

adamkotwasinski
Copy link
Contributor

@adamkotwasinski adamkotwasinski commented Aug 9, 2023

Commit Message: kafka: upgrade dependencies to 3.5.1
Additional Description: upgrade dependencies, the newest message type is not supported because I still need to deliver some more code there; should be safe to backport (because it's only Kafka protocol)
Risk Level: Low
Testing: integration testing with full stack; manual testing with envoy-kafka-tests
Docs Changes: version numbers
Release Notes: N/A
Platform Specific Features: N/A

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #28932 was opened by adamkotwasinski.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Aug 9, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #28932 was opened by adamkotwasinski.

see: more, trace.

@phlax
Copy link
Member

phlax commented Aug 9, 2023

/backport

@repokitteh-read-only repokitteh-read-only bot added the backport/review Request to backport to stable releases label Aug 9, 2023
@adamkotwasinski
Copy link
Contributor Author

/retest

@adamkotwasinski
Copy link
Contributor Author

Weirdness. Repokitteh didn't restart my builds. Here we go again.

@phlax
Copy link
Member

phlax commented Aug 10, 2023

#28934

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@adamkotwasinski
Copy link
Contributor Author

Ready for review - it finally builds!

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Aug 16, 2023
@mattklein123 mattklein123 merged commit ffb25ce into envoyproxy:main Aug 16, 2023
121 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Aug 17, 2023
This reverts commit ffb25ce.

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Aug 18, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Aug 18, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
cqi1217 pushed a commit to cqi1217/envoy that referenced this pull request Aug 21, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: cqi1217 <caiqi1217@gmail.com>
phlax pushed a commit that referenced this pull request Aug 21, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Aug 22, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Aug 22, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Aug 25, 2023
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@adamkotwasinski adamkotwasinski deleted the kafka-351 branch October 3, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/review Request to backport to stable releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants