-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make trie structure less memory-hogging #33668
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ddb0b72
Make trie structure less memory-hogging
ravenblackx 5a9d39c
Spelling
ravenblackx ca28226
Embarrassing off-by-one error, and remove unnecessary c_str
ravenblackx d227b72
Initialize min_child_ to satisfy msan, reorder branch to hint likely …
ravenblackx 151142c
Trie can support non-pointer value types.
ravenblackx 02a6c2c
Benchmarks
ravenblackx 4d41919
Spelling and expand range
ravenblackx 70fddd3
Merge branch 'main' into trie_space
ravenblackx e3a9d5e
Split TrieEntry implementation into Fast/Small
ravenblackx f03ea15
Fix warning - Value passed to --benchmark_min_time should have a suff…
ravenblackx 1fa7ee9
Rename to Big, add benchmarks specifically for static headers
ravenblackx e5e1d36
Make speed test capable of testing any lookups
ravenblackx 54b417a
Spelling
ravenblackx f02e4ed
const
ravenblackx 8a07a4c
not const
ravenblackx 638e8d6
Const and non-const versions (though only the non-const is ever used)
ravenblackx b8e653c
Merge branch 'main' into trie_space
ravenblackx 1c47849
Unify the implementation
ravenblackx 7281ca8
Comment nit
ravenblackx bc5439e
Empty to trigger CI
ravenblackx f7ce79d
Explicit parens
ravenblackx a0fc01e
==nullptr rather than !
ravenblackx bb0a24e
Add comment about type of Value
ravenblackx 03e5101
The nittiest spelling correction ever
ravenblackx 29b69d0
Empty commit because Amazon sucks at agents
ravenblackx f681a4d
Improve names, private TrieNode, improve comments
ravenblackx f296e98
Clarify description of findLongestPrefix too
ravenblackx 7f965cd
Child character c instead of child key
ravenblackx 3939544
c => child_index
ravenblackx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is never used, what happens if you comment it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, of course it's used because the find() is const, I'm totally wrong.