Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: hold shared_ptr to configs to avoid use-after-free #33826

Merged
merged 1 commit into from
Apr 29, 2024

config: hold shared_ptr to configs to avoid use-after-free

7af7d23
Select commit
Failed to load commit list.
Merged

config: hold shared_ptr to configs to avoid use-after-free #33826

config: hold shared_ptr to configs to avoid use-after-free
7af7d23
Select commit
Failed to load commit list.
CI (Envoy) / Mobile/CC succeeded Apr 26, 2024 in 15m 53s

Mobile/CC (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/CC (pr/33826/main@7af7d23)

Check started by

Request (pr/33826/main@7af7d23)

ggreenway @ggreenway 7af7d23 #33826 merge main@14c7edf

config: hold shared_ptr to configs to avoid use-after-free

Commit Message:
Additional Description: Followup after investigation for #33805. I haven't observed any crashes from these filters, but they seem likely to have similar issues to the one seen in the HCM.
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref 28201d7
sha 7af7d23
pr 33826
base-sha 14c7edf
actor ggreenway @ggreenway
message config: hold shared_ptr to configs to avoid use-after-free...
started 1714163338.54907
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true