Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding streaming response to AdminClusters endpoint #33879

Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Adding streaming response to AdminClusters endpoint #33879

wants to merge 77 commits into from

Commits on Jun 6, 2024

  1. Add support for boolean type to Envoy::Json::Streamer 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    22a6e7d View commit details
    Browse the repository at this point in the history

  2. Harden variant selection with static_assert 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    797c8ca View commit details
    Browse the repository at this point in the history

  3. Remove unused variable 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b2dc336 View commit details
    Browse the repository at this point in the history

  4. Setup new request route for /clusters 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    85275f8 View commit details
    Browse the repository at this point in the history

  5. Updating documentation comments. 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0a0245e View commit details
    Browse the repository at this point in the history

  6. Adding boilerplate for clusters_request.cc 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2ed400a View commit details
    Browse the repository at this point in the history

  7. Small update set 

    * Using more accurate calculation for 2 MB
* Adding clusters_request_test.cc
* Changing the route configuration to match expected output in test

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ecec95d View commit details
    Browse the repository at this point in the history

  8. Adding preliminary unit testing for clusters_request.cc 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6f36f5c View commit details
    Browse the repository at this point in the history

  9. Adding ClustersParams struct 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    eeb5fbc View commit details
    Browse the repository at this point in the history

  10. Add dependency on ClustersParams to ClustersRequest 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0060cce View commit details
    Browse the repository at this point in the history

  11. Adding the interface for ClustersRenderer. 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c104f43 View commit details
    Browse the repository at this point in the history

  12. Adding ClustersRenderer implementation boilerplate 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    233def0 View commit details
    Browse the repository at this point in the history

  13. Implemented ClustersRequest 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    71c3b3e View commit details
    Browse the repository at this point in the history

  14. Updating unit tests to accommodate new dependencies 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a6658f6 View commit details
    Browse the repository at this point in the history

  15. Implement ClustersTextRenderer 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c9c7d3a View commit details
    Browse the repository at this point in the history

  16. Modify iteration strategy for the text renderer 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1638f2e View commit details
    Browse the repository at this point in the history

  17. Implement render to simplify nextChunk 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    253b0d2 View commit details
    Browse the repository at this point in the history

  18. Add clusters_params_test.cc 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d19238a View commit details
    Browse the repository at this point in the history

  19. Refactor of rendering. 

    Separate cluster rendering from iteration.

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f4600ba View commit details
    Browse the repository at this point in the history

  20. refactor and start Json implementation 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6b5cc1d View commit details
    Browse the repository at this point in the history

  21. Json processing working 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1d9ba05 View commit details
    Browse the repository at this point in the history

  22. Adding addCircuitBreakerSettingsAsJson 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3aadf0d View commit details
    Browse the repository at this point in the history

  23. Fixing test with addCircuitBreakerSettingsAsJson 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8715ec0 View commit details
    Browse the repository at this point in the history

  24. Format update 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    423d769 View commit details
    Browse the repository at this point in the history

  25. Small refactor for circuit breaker rendering 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f37ef5a View commit details
    Browse the repository at this point in the history

  26. Fixed mocking for Upstream::Cluster 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7bf62d4 View commit details
    Browse the repository at this point in the history

  27. Fix formatting 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d2e6ddb View commit details
    Browse the repository at this point in the history

  28. Add added_via_api 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4c1ce2f View commit details
    Browse the repository at this point in the history

  29. Save progress on host config 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9f9152f View commit details
    Browse the repository at this point in the history

  30. Fix formatting 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d25966f View commit details
    Browse the repository at this point in the history

  31. Fix formatting 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0dd628f View commit details
    Browse the repository at this point in the history

  32. Host config code building 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a82222c View commit details
    Browse the repository at this point in the history

  33. Saving progress on testing host config 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4b0daf6 View commit details
    Browse the repository at this point in the history

  34. Saving progress on testing host config 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    84e92bd View commit details
    Browse the repository at this point in the history

  35. Saving progress on testing host config 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ed7e066 View commit details
    Browse the repository at this point in the history

  36. Saving progress on testing host config 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    161adcd View commit details
    Browse the repository at this point in the history

  37. Save point 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fa698e4 View commit details
    Browse the repository at this point in the history

  38. Test passing for json streaming 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ce42c2a View commit details
    Browse the repository at this point in the history

  39. Using absl::btree_map instead of absl::flat_hash_map for deterministi… 

    …c output

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1db72b4 View commit details
    Browse the repository at this point in the history

  40. Some minor fixes and formating changes 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a171714 View commit details
    Browse the repository at this point in the history

  41. VerifyTextOutput done 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    485dd01 View commit details
    Browse the repository at this point in the history

  42. Format fix 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    15c1dd3 View commit details
    Browse the repository at this point in the history

  43. Remove temp files 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    75a8590 View commit details
    Browse the repository at this point in the history

  44. Handle omission of empty object 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a23e9ec View commit details
    Browse the repository at this point in the history

  45. Set content type header for JSON output to satisfy integration tests 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fe47bf2 View commit details
    Browse the repository at this point in the history

  46. Fix spelling issue and update comments 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e2eec3a View commit details
    Browse the repository at this point in the history

  47. Fix formatting 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    fdf459a View commit details
    Browse the repository at this point in the history

  48. Fix odd bug in gcc 11.4.0 build 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    ccc5f45 View commit details
    Browse the repository at this point in the history

  49. Fix some formatting issues 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    97690ed View commit details
    Browse the repository at this point in the history

  50. Remove unused import 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bbba348 View commit details
    Browse the repository at this point in the history

  51. Set text content type and prevent unnecessary fallthrough in switch s… 

    …tatement

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c0dc33f View commit details
    Browse the repository at this point in the history

  52. Allow default content type for text processing 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6a93146 View commit details
    Browse the repository at this point in the history

  53. Remove build target that is not yet used 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    65574bd View commit details
    Browse the repository at this point in the history

  54. Remove unused import 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c1a9934 View commit details
    Browse the repository at this point in the history

  55. Remove declaration from when member functions where static functions 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a7e4a78 View commit details
    Browse the repository at this point in the history

  56. Remove redundant ternary expression 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3175c39 View commit details
    Browse the repository at this point in the history

  57. Removing designated initialization since C++20 is not yet supported 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    bae0781 View commit details
    Browse the repository at this point in the history

  58. Using a vector and sorting instead of std::map 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c7f4ece View commit details
    Browse the repository at this point in the history

  59. Formatting fix 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    12347d2 View commit details
    Browse the repository at this point in the history

  60. Use structured bindings in loop 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    d5bc39b View commit details
    Browse the repository at this point in the history

  61. Add TODO comment for adding designated initialization in handler conf… 

    …ig when C++20 is supported

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    3bcfdf7 View commit details
    Browse the repository at this point in the history

  62. Fix spelling 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9c95663 View commit details
    Browse the repository at this point in the history

  63. Wrapped reference to reference 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c096e71 View commit details
    Browse the repository at this point in the history

  64. Adding anonymous namespace for the unit tests 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    188aa47 View commit details
    Browse the repository at this point in the history

  65. Return Http::Code::BadRequest if format query parameter is invalid 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    63edb28 View commit details
    Browse the repository at this point in the history

  66. Update unit tests for ClustersParams 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1aaabac View commit details
    Browse the repository at this point in the history

  67. Updating ClustersHandler::makeRequest to return text response when qu… 

    …ery param parsing fails

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    db88b19 View commit details
    Browse the repository at this point in the history

  68. Implement nextChunk within sub classes of Request 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8c5790c View commit details
    Browse the repository at this point in the history

  69. Remove cluster chunk processor since nextChunk is fully implemented i… 

    …n the request classes

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    594b51c View commit details
    Browse the repository at this point in the history

  70. Resolve: control reaches end of non-void function 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7379a1e View commit details
    Browse the repository at this point in the history

  71. Remove unused code from the clusters_params_test 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f910712 View commit details
    Browse the repository at this point in the history

  72. Remove raw pointers from API surface in clusters_request.h and cluste… 

    …rs_request.cc

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    22c5961 View commit details
    Browse the repository at this point in the history

  73. Remove default case from switch statement in clusters_handler 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c9b9131 View commit details
    Browse the repository at this point in the history

  74. Remove default constructor for ClustersParams and add necessary break… 

    … statement to switch in clusters_handler

Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7271018 View commit details
    Browse the repository at this point in the history

  75. Remove UNKNOWN format from ClustersParams 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c8d379b View commit details
    Browse the repository at this point in the history

  76. Update documentation comment for ClustersRequest 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    51ab1e1 View commit details
    Browse the repository at this point in the history

  77. Cleanup unit tests 

    Signed-off-by: Demitri Swan <demitriswan@google.com>
    @miroswan
    miroswan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6bb869e View commit details
    Browse the repository at this point in the history