-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding streaming response to AdminClusters endpoint #33879
Commits on Jun 6, 2024
-
Add support for boolean type to Envoy::Json::Streamer
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 22a6e7d - Browse repository at this point
Copy the full SHA 22a6e7dView commit details -
Harden variant selection with static_assert
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 797c8ca - Browse repository at this point
Copy the full SHA 797c8caView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for b2dc336 - Browse repository at this point
Copy the full SHA b2dc336View commit details -
Setup new request route for /clusters
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 85275f8 - Browse repository at this point
Copy the full SHA 85275f8View commit details -
Updating documentation comments.
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 0a0245e - Browse repository at this point
Copy the full SHA 0a0245eView commit details -
Adding boilerplate for clusters_request.cc
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 2ed400a - Browse repository at this point
Copy the full SHA 2ed400aView commit details -
* Using more accurate calculation for 2 MB * Adding clusters_request_test.cc * Changing the route configuration to match expected output in test Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for ecec95d - Browse repository at this point
Copy the full SHA ecec95dView commit details -
Adding preliminary unit testing for clusters_request.cc
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 6f36f5c - Browse repository at this point
Copy the full SHA 6f36f5cView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for eeb5fbc - Browse repository at this point
Copy the full SHA eeb5fbcView commit details -
Add dependency on ClustersParams to ClustersRequest
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 0060cce - Browse repository at this point
Copy the full SHA 0060cceView commit details -
Adding the interface for ClustersRenderer.
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c104f43 - Browse repository at this point
Copy the full SHA c104f43View commit details -
Adding ClustersRenderer implementation boilerplate
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 233def0 - Browse repository at this point
Copy the full SHA 233def0View commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 71c3b3e - Browse repository at this point
Copy the full SHA 71c3b3eView commit details -
Updating unit tests to accommodate new dependencies
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for a6658f6 - Browse repository at this point
Copy the full SHA a6658f6View commit details -
Implement ClustersTextRenderer
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c9c7d3a - Browse repository at this point
Copy the full SHA c9c7d3aView commit details -
Modify iteration strategy for the text renderer
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 1638f2e - Browse repository at this point
Copy the full SHA 1638f2eView commit details -
Implement render to simplify nextChunk
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 253b0d2 - Browse repository at this point
Copy the full SHA 253b0d2View commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for d19238a - Browse repository at this point
Copy the full SHA d19238aView commit details -
Separate cluster rendering from iteration. Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for f4600ba - Browse repository at this point
Copy the full SHA f4600baView commit details -
refactor and start Json implementation
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 6b5cc1d - Browse repository at this point
Copy the full SHA 6b5cc1dView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 1d9ba05 - Browse repository at this point
Copy the full SHA 1d9ba05View commit details -
Adding addCircuitBreakerSettingsAsJson
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 3aadf0d - Browse repository at this point
Copy the full SHA 3aadf0dView commit details -
Fixing test with addCircuitBreakerSettingsAsJson
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8715ec0 - Browse repository at this point
Copy the full SHA 8715ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 423d769 - Browse repository at this point
Copy the full SHA 423d769View commit details -
Small refactor for circuit breaker rendering
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for f37ef5a - Browse repository at this point
Copy the full SHA f37ef5aView commit details -
Fixed mocking for Upstream::Cluster
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 7bf62d4 - Browse repository at this point
Copy the full SHA 7bf62d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2e6ddb - Browse repository at this point
Copy the full SHA d2e6ddbView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 4c1ce2f - Browse repository at this point
Copy the full SHA 4c1ce2fView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 9f9152f - Browse repository at this point
Copy the full SHA 9f9152fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d25966f - Browse repository at this point
Copy the full SHA d25966fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dd628f - Browse repository at this point
Copy the full SHA 0dd628fView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for a82222c - Browse repository at this point
Copy the full SHA a82222cView commit details -
Saving progress on testing host config
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 4b0daf6 - Browse repository at this point
Copy the full SHA 4b0daf6View commit details -
Saving progress on testing host config
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 84e92bd - Browse repository at this point
Copy the full SHA 84e92bdView commit details -
Saving progress on testing host config
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for ed7e066 - Browse repository at this point
Copy the full SHA ed7e066View commit details -
Saving progress on testing host config
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 161adcd - Browse repository at this point
Copy the full SHA 161adcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa698e4 - Browse repository at this point
Copy the full SHA fa698e4View commit details -
Test passing for json streaming
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for ce42c2a - Browse repository at this point
Copy the full SHA ce42c2aView commit details -
Using absl::btree_map instead of absl::flat_hash_map for deterministi…
…c output Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 1db72b4 - Browse repository at this point
Copy the full SHA 1db72b4View commit details -
Some minor fixes and formating changes
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for a171714 - Browse repository at this point
Copy the full SHA a171714View commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 485dd01 - Browse repository at this point
Copy the full SHA 485dd01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c1dd3 - Browse repository at this point
Copy the full SHA 15c1dd3View commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 75a8590 - Browse repository at this point
Copy the full SHA 75a8590View commit details -
Handle omission of empty object
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for a23e9ec - Browse repository at this point
Copy the full SHA a23e9ecView commit details -
Set content type header for JSON output to satisfy integration tests
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for fe47bf2 - Browse repository at this point
Copy the full SHA fe47bf2View commit details -
Fix spelling issue and update comments
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for e2eec3a - Browse repository at this point
Copy the full SHA e2eec3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fdf459a - Browse repository at this point
Copy the full SHA fdf459aView commit details -
Fix odd bug in gcc 11.4.0 build
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for ccc5f45 - Browse repository at this point
Copy the full SHA ccc5f45View commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 97690ed - Browse repository at this point
Copy the full SHA 97690edView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for bbba348 - Browse repository at this point
Copy the full SHA bbba348View commit details -
Set text content type and prevent unnecessary fallthrough in switch s…
…tatement Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c0dc33f - Browse repository at this point
Copy the full SHA c0dc33fView commit details -
Allow default content type for text processing
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 6a93146 - Browse repository at this point
Copy the full SHA 6a93146View commit details -
Remove build target that is not yet used
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 65574bd - Browse repository at this point
Copy the full SHA 65574bdView commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c1a9934 - Browse repository at this point
Copy the full SHA c1a9934View commit details -
Remove declaration from when member functions where static functions
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for a7e4a78 - Browse repository at this point
Copy the full SHA a7e4a78View commit details -
Remove redundant ternary expression
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 3175c39 - Browse repository at this point
Copy the full SHA 3175c39View commit details -
Removing designated initialization since C++20 is not yet supported
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for bae0781 - Browse repository at this point
Copy the full SHA bae0781View commit details -
Using a vector and sorting instead of std::map
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c7f4ece - Browse repository at this point
Copy the full SHA c7f4eceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12347d2 - Browse repository at this point
Copy the full SHA 12347d2View commit details -
Use structured bindings in loop
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for d5bc39b - Browse repository at this point
Copy the full SHA d5bc39bView commit details -
Add TODO comment for adding designated initialization in handler conf…
…ig when C++20 is supported Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 3bcfdf7 - Browse repository at this point
Copy the full SHA 3bcfdf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c95663 - Browse repository at this point
Copy the full SHA 9c95663View commit details -
Wrapped reference to reference
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c096e71 - Browse repository at this point
Copy the full SHA c096e71View commit details -
Adding anonymous namespace for the unit tests
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 188aa47 - Browse repository at this point
Copy the full SHA 188aa47View commit details -
Return Http::Code::BadRequest if format query parameter is invalid
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 63edb28 - Browse repository at this point
Copy the full SHA 63edb28View commit details -
Update unit tests for ClustersParams
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 1aaabac - Browse repository at this point
Copy the full SHA 1aaabacView commit details -
Updating ClustersHandler::makeRequest to return text response when qu…
…ery param parsing fails Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for db88b19 - Browse repository at this point
Copy the full SHA db88b19View commit details -
Implement nextChunk within sub classes of Request
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 8c5790c - Browse repository at this point
Copy the full SHA 8c5790cView commit details -
Remove cluster chunk processor since nextChunk is fully implemented i…
…n the request classes Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 594b51c - Browse repository at this point
Copy the full SHA 594b51cView commit details -
Resolve: control reaches end of non-void function
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 7379a1e - Browse repository at this point
Copy the full SHA 7379a1eView commit details -
Remove unused code from the clusters_params_test
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for f910712 - Browse repository at this point
Copy the full SHA f910712View commit details -
Remove raw pointers from API surface in clusters_request.h and cluste…
…rs_request.cc Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 22c5961 - Browse repository at this point
Copy the full SHA 22c5961View commit details -
Remove default case from switch statement in clusters_handler
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c9b9131 - Browse repository at this point
Copy the full SHA c9b9131View commit details -
Remove default constructor for ClustersParams and add necessary break…
… statement to switch in clusters_handler Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 7271018 - Browse repository at this point
Copy the full SHA 7271018View commit details -
Remove UNKNOWN format from ClustersParams
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for c8d379b - Browse repository at this point
Copy the full SHA c8d379bView commit details -
Update documentation comment for ClustersRequest
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 51ab1e1 - Browse repository at this point
Copy the full SHA 51ab1e1View commit details -
Signed-off-by: Demitri Swan <demitriswan@google.com>
Configuration menu - View commit details
-
Copy full SHA for 6bb869e - Browse repository at this point
Copy the full SHA 6bb869eView commit details