-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement setOperation for the opentelemetry provider #34062
Conversation
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com>
Hi @therealak12, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
The
|
its actually a slightly different error ( /retest |
Thanks for rerunning the /retest |
Haha. 😂 |
@therealak12 a sandbox test is helpful also, but probably this shoud have some code test if its critical to functionality |
@phlax |
I'm going to mark the PR as draft till I add the tests. |
Signed-off-by: Ahmad Karimi <ak12hastam@gmail.com>
/retest |
@phlax |
Dear @htuch; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Commit Message: implement setOperation for the opentelemetry provider
Additional Description:
The detailed description is provided in issue#34063. In short, the MR implements a method for the OpenTelemetry tracing provider that was left empty and thus made the
setOperation
method a no-op.Risk Level: Low
Testing: Unit testing and the sandbox.
Fixes issue#34063