Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: static linking for sanitizers #34306

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 22, 2024

Looks like this is slightly better as it catches things dynamic linking did not.

Risk Level: n/a (test only)
Testing: CI
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34306 was opened by alyssawilk.

see: more, trace.

@alyssawilk
Copy link
Contributor Author

hey OT folks: looks like we can simplify our ASAN/TSAN builds (and catch more errors) but the OT tests are failing with what looks like a legit upstream OT error:
https://dev.azure.com/cncf/envoy/_build/results?buildId=171145&view=logs&j=110f9f1f-b6b9-58c8-998b-c13d0a153720&t=5732c66a-8745-5a51-7c56-30d8204ec51b&l=199
can one of you PTAL?
@wbpcode @Shikugawa @basvanbeek

@alyssawilk
Copy link
Contributor Author

/retest

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite remember what was the original reason for this, probably due to some build constraints (too big binary?) but if it works it should be fine.

@alyssawilk alyssawilk merged commit 195430b into envoyproxy:main May 29, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants