Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename getTraceIdAsHex to getTraceId #34314

Merged
merged 4 commits into from
May 27, 2024

fix test

d016c16
Select commit
Loading
Failed to load commit list.
Merged

rename getTraceIdAsHex to getTraceId #34314

fix test
d016c16
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/TSAN skipped May 23, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/34314/main@d016c16)

zirain @zirain d016c16 #34314 merge main@ec19828

rename getTraceIdAsHex to getTraceId

Commit Message: rename getTraceIdAsHex to getTraceId, becasuse not all tracer providers use hex format trace id.
Additional Description: follow up #34198
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Environment

Request variables

Key Value
ref 33b8c24
sha d016c16
pr 34314
base-sha ec19828
actor zirain @zirain
message rename getTraceIdAsHex to getTraceId...
started 1716457858.198456
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 31
patch 0
dev true