rename getTraceIdAsHex to getTraceId #34314
Merged
CI (Envoy) / Envoy/macOS
succeeded
May 23, 2024 in 6m 53s
Envoy/macOS (success)
Check has finished
Details
Check run finished (success ✔️)
The check run can be viewed here:
Envoy/macOS (pr/34314/main@d016c16)
Check started by
Request (pr/34314/main@d016c16)
@zirain d016c16
#34314 merge
main@ec19828
rename getTraceIdAsHex to getTraceId
Commit Message: rename
getTraceIdAsHex
togetTraceId
, becasuse not all tracer providers use hex format trace id.
Additional Description: follow up #34198
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
Environment
Request variables
Key | Value |
---|---|
ref | 33b8c24 |
sha | d016c16 |
pr | 34314 |
base-sha | ec19828 |
actor | @zirain |
message | rename getTraceIdAsHex to getTraceId... |
started | 1716457858.198456 |
target-branch | main |
trusted | false |
Build image
Container image/s (as used in this CI run)
Key | Value |
---|---|
default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
Key | Value |
---|---|
major | 1 |
minor | 31 |
patch | 0 |
dev | true |
Loading