http2: removes environment variable-triggered nghttp2 logging #34354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Biren Roy <birenroy@google.com>
|
I found it useful to enable nghttp2 logs occasionally. Is there a way to enable detailed logs for oghttp2? /wait-any |
Yes, there's a QUICHE flag that can be enabled: I'm not sure how to set QUICHE flags for a locally running Envoy, but setting that flag should get you wire format events logged at the |
yanavlasov
approved these changes
May 28, 2024
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Jun 24, 2024
…envoyproxy#34354)" This reverts commit 14cd80f. Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Jun 25, 2024
…envoyproxy#34354)" This reverts commit 14cd80f. Signed-off-by: Yan Avlasov <yavlasov@google.com>
alyssawilk
pushed a commit
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logging is not covered by tests, and is less relevant with the HTTP/2 codec switchover.
The stringent code coverage limits have caused problems for past pull requests, so might as well eliminate one source of uncovered lines.
Commit Message: http2: removes environment variable-triggered nghttp2 logging
Additional Description:
Risk Level: low
Testing: ran integration tests and http/2 unit tests
Docs Changes:
Release Notes:
Platform Specific Features: