Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: removes environment variable-triggered nghttp2 logging #34354

Merged
merged 1 commit into from
May 28, 2024
Merged

http2: removes environment variable-triggered nghttp2 logging #34354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions source/common/http/http2/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,6 @@ envoy_cc_library(
],
)

# Separate library for some nghttp2 setup stuff to avoid having tests take a
# dependency on everything in codec_lib.
envoy_cc_library(
name = "nghttp2_lib",
srcs = ["nghttp2.cc"],
hdrs = ["nghttp2.h"],
external_deps = ["nghttp2"],
deps = [
"//source/common/common:minimal_logger_lib",
],
)

envoy_cc_library(
name = "conn_pool_lib",
srcs = ["conn_pool.cc"],
Expand Down
35 changes: 0 additions & 35 deletions source/common/http/http2/nghttp2.cc
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions source/common/http/http2/nghttp2.h
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion source/exe/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ envoy_cc_library(
deps = [
"//source/common/common:assert_lib",
"//source/common/event:libevent_lib",
"//source/common/http/http2:nghttp2_lib",
"//source/common/network/dns_resolver:dns_factory_util_lib",
"//source/server:proto_descriptors_lib",
],
Expand Down
2 changes: 0 additions & 2 deletions source/exe/process_wide.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include "source/common/common/assert.h"
#include "source/common/event/libevent.h"
#include "source/common/http/http2/nghttp2.h"
#include "source/server/proto_descriptors.h"

namespace Envoy {
Expand Down Expand Up @@ -38,7 +37,6 @@ ProcessWide::ProcessWide(bool validate_proto_descriptors) {
#else
UNREFERENCED_PARAMETER(validate_proto_descriptors);
#endif
Http::Http2::initializeNghttp2Logging();

// We do not initialize Google gRPC here -- we instead instantiate
// Grpc::GoogleGrpcContext in MainCommon immediately after instantiating
Expand Down