Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "generic proxy: move generic proxy from contrib into extension… #35119

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Jul 9, 2024

Looks like it broke prechecks

envoyproxy#34892)"

This reverts commit 0dbd441.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #35119 was opened by alyssawilk.

see: more, trace.

Copy link
Contributor

@ravenblackx ravenblackx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory-check approve for a revert.

@alyssawilk alyssawilk merged commit 6145b7e into envoyproxy:main Jul 9, 2024
32 of 44 checks passed
alyssawilk added a commit to alyssawilk/envoy that referenced this pull request Jul 9, 2024
…n… (envoyproxy#35119)

This reverts commit 6145b7e.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
wbpcode added a commit to wbpcode/envoy that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants