Envoy Mobile: making exception-free build the default #35093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
exceptions
branch
2 times, most recently
from
6cc7aca
to
c758ec8
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
wbpcode,
RyanTheOptimist,
abeyad,
fredyw and
mattklein123
as code owners
|
@phlax can you make sure I removed the compile time options build correctly? After that you can remove yourself as a reviewer. |
RyanTheOptimist
previously approved these changes
Jul 8, 2024
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
ugh, did a main merge to handle conflicts, but that broke prechecks because it's broken at HEAD. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
RyanTheOptimist
approved these changes
Jul 9, 2024
RyanTheOptimist
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a number of Envoy throw EnvoyException calls to use the wrapper throwEnvoyExceptionOrPanic (which for Envoy should still resolve to "throw EnvoyException", so should be a no-op)
Risk Level: low
Testing: existing CI
Docs Changes: n/a
Release Notes: n/a