Make DownstreamTiming a struct, instead of a class #36473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ThomasHabets, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
This makes it consistent with UpstreamTiming, and makes it easier to dependency inject timing info for testing. Signed-off-by: Thomas Habets <habets@google.com>
ThomasHabets
force-pushed
the
unprivate
branch
from
3c36d29
to
276fe38
Compare
RyanTheOptimist
approved these changes
Oct 7, 2024
anitabyte
pushed a commit
to anitabyte/envoy
that referenced
this pull request
Oct 9, 2024
Commit Message: Make DownstreamTiming a struct, instead of a class Additional Description:This makes it consistent with UpstreamTiming, and makes it easier to dependency inject timing info for testing. Risk Level: WCPGW Testing: None Docs Changes: None Release Notes: None Platform Specific Features: None Signed-off-by: Thomas Habets <habets@google.com> Signed-off-by: anitabyte <anita@anitabyte.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Make DownstreamTiming a struct, instead of a class
Additional Description:This makes it consistent with UpstreamTiming, and makes it easier to dependency inject timing info for testing.
Risk Level: WCPGW
Testing: None
Docs Changes: None
Release Notes: None
Platform Specific Features: None