Re-order functions in stats_impl to group classes together #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This reverts commit 769be4f. Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ther. Signed-off-by: Joshua Marantz <jmarantz@google.com>
….cc. And un-inline much of IsolatedStoreImpl, to avoid having to recompile its large ctor with every other file in Envoy. Signed-off-by: Joshua Marantz <jmarantz@google.com>
jmarantz
commented
Jul 31, 2018
|
@jmarantz if you are going to do a code move PR would you prefer to split the files? Up to you. I could see it definitely helping with readability. |
|
sure -- np. Hold off on the review please; I'll split them up. Splitting the include will likely greatly expand the # of files in the CL but I'll keep it non-functional, so hopefully it'll still be easy to review. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
… to its own file. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
|
That was definitely a lot more work. This change is again entirely non-functional; just moving stuff around. A fast review would be good here as this PR is highly prone to master merge conflicts. If you want to suggest changes to this org -- and they are not too pervasive -- it would also be better to do those as a follow-up; again due to potential issues with a delayed master merge. |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: stats_impl.cc/h is actually about 4 or 5 different classes which are not that tightly coupled. For include minimalism and being able to find what you are looking for easily, this PR breaks them up:
heap_stat_data.h metric_impl.h stats_impl.h tag_producer_impl.h
histogram_impl.h raw_stat_data.h stats_options_impl.h thread_local_store.h
isolated_store_impl.h stat_data_allocator.h tag_extractor_impl.h utility.h
There are now 1 or 2 tightly related classes per file.
Follow-up PRs are needed to break up stats_impl_test.cc and to rename stats_impl.h to stats_store.h, changing the 60+ refs to that.
Follow-up to #3710
Risk Level: Low
Testing: //test/...
Docs Changes: N/A
Release Notes: N/A