Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-order functions in stats_impl to group classes together #4004

Merged
merged 14 commits into from
Aug 1, 2018
Merged

Re-order functions in stats_impl to group classes together #4004

merged 14 commits into from
Aug 1, 2018

Commits on Jul 31, 2018

  1. Re-order functions to group classes together. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    769be4f View commit details
    Browse the repository at this point in the history

  2. Revert "Re-order functions to group classes together." 

    This reverts commit 769be4f.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    e50e73d View commit details
    Browse the repository at this point in the history

  3. re-order functions to group implementations of different classes toge… 

    …ther.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    6f594b5 View commit details
    Browse the repository at this point in the history

  4. A little more aggressively, make the class order match between .h an … 

    ….cc.

And un-inline much of IsolatedStoreImpl, to avoid having to recompile
its large ctor with every other file in Envoy.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    109ab12 View commit details
    Browse the repository at this point in the history

  5. Split out Stats::Utility into its own files. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    5a0a7bb View commit details
    Browse the repository at this point in the history

  6. Split out StatsOptions into separate files. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Jul 31, 2018
    Configuration menu
    Copy the full SHA
    77375e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. Split out tag-extractor to its own file. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    69da286 View commit details
    Browse the repository at this point in the history

  2. Split out TagProducer. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    5106bae View commit details
    Browse the repository at this point in the history

  3. Spelling error, formatting fixes, and verified //test/... passes. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    dfd05ac View commit details
    Browse the repository at this point in the history

  4. Break out IsoaltedStore into a separate file. Man this was painful. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    871c1a3 View commit details
    Browse the repository at this point in the history

  5. Split out HeapStatData and MetricsImpl, moving the allocator template… 

    … to its own file.

Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    9c10931 View commit details
    Browse the repository at this point in the history

  6. Pull out HistogramImpl and HistogramStatisticsImpl into their own file. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    64e8c9c View commit details
    Browse the repository at this point in the history

  7. rename histogram.* to histogram_impl.* for consistency. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    9248ee1 View commit details
    Browse the repository at this point in the history

  8. Add a comment to re-kick CI. 

    Signed-off-by: Joshua Marantz <jmarantz@google.com>
    @jmarantz
    jmarantz committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    571b8d3 View commit details
    Browse the repository at this point in the history