Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update build image #6866

Merged
merged 14 commits into from
Jun 3, 2019
Merged

ci: update build image #6866

merged 14 commits into from
Jun 3, 2019

Conversation

lizan
Copy link
Member

@lizan lizan commented May 9, 2019

Signed-off-by: Lizan Zhou lizan@tetrate.io

Description:
Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:

lizan added 2 commits May 9, 2019 00:24
@lizan
ci: update build image
4d0b7e1 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
fix ci runs
1bf4b36 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested review from htuch and mattklein123 May 10, 2019 02:18
htuch
htuch previously approved these changes May 10, 2019
View reviewed changes
@dio
Copy link
Member

dio commented May 14, 2019

@lizan is this (the mac build) hanging?

image

htuch
htuch reviewed May 14, 2019
View reviewed changes
ci/run_clang_tidy.sh Outdated
@@ -16,6 +16,9 @@ trap cleanup EXIT
# Writing them into bazelrc
echo "build ${BAZEL_BUILD_OPTIONS}" >> .bazelrc

# TODO(lizan): remove this once https://github.com/grailbio/bazel-compilation-database/issues/25 is fixed.
echo "build --incompatible_disable_legacy_cc_provider=false" >> .bazelrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I only just read how this .bazelrc thing works today; it's pretty funky but I would much rather we switched to another build directory and created an ephemeral .bazelrc, e.g. what happens if you interrupt the local clang-tidy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the trap EXIT worked, though we don't need this any more as upstream issue is resolved, and we don't have ci WORKSPACE anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked providing you get the signal; if you nuke the Docker image or something, you don't get that.

ci/do_ci.sh Outdated
@@ -215,7 +215,7 @@ elif [[ "$1" == "bazel.coverage" ]]; then

# gcovr is a pain to run with `bazel run`, so package it up into a
# relocatable and hermetic-ish .par file.
bazel build @com_github_gcovr_gcovr//:gcovr.par
bazel build --incompatible_remove_old_python_version_api=false @com_github_gcovr_gcovr//:gcovr.par
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a tracking bug to clean this one up? Hoping not to be too surprised at a Bazel point release.

@lizan
update clang-tidy run
07fbaed 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@htuch
Copy link
Member

htuch commented May 16, 2019

@lizan failing clang_tidy on CI.

@htuch htuch added the waiting label May 20, 2019
@stale
Copy link

stale bot commented May 24, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 24, 2019
@lizan lizan mentioned this pull request May 24, 2019
Closed
@hlopko hlopko mentioned this pull request May 28, 2019
Closed
@hlopko
Copy link
Contributor

hlopko commented May 28, 2019

Hi @htuch @lizan, can we move forward with this cl? Is there a concrete problem or just lack of time and more urgent priorities?

Regarding --incompatible_disable_legacy_cc_provider, is seems grailbio/bazel-compilation-database#25 is fixed.

Regarding incompatible_remove_old_python_version_api and gcovr, what exactly is the issue? Can we just migrate for that flag? bazelbuild/bazel#7308 has decent migration instructions.

Thanks!

@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 28, 2019
@htuch
Copy link
Member

htuch commented May 28, 2019

Happy to rubber stamp if we can get CI passing @hlopko @lizan

lizan added 4 commits May 30, 2019 00:12
@lizan
remove --incompatible_remove_old_python_version_api
a12f580 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
revert tidy script
a693087 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
--incompatible_depset_union=false
5bbacc3 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
0.26 compat
6346d1f 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan
azure image
2905be7 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@htuch
Copy link
Member

htuch commented May 30, 2019

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: ipv6_tests (failed build)
🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6866 (comment) was created by @htuch.

see: more, trace.

htuch
htuch previously approved these changes May 30, 2019
View reviewed changes
@lizan
test
320cadd 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan mentioned this pull request May 31, 2019
Closed
@lizan
Copy link
Member Author

lizan commented May 31, 2019

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6866 (comment) was created by @lizan.

see: more, trace.

@lizan
fix coverage
94667d8 
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from htuch June 3, 2019 20:09
@lizan lizan merged commit f1cf265 into envoyproxy:master Jun 3, 2019
@lizan lizan deleted the update_image branch June 3, 2019 20:41
@jmarantz jmarantz mentioned this pull request Jun 7, 2019
Closed
@htuch htuch mentioned this pull request Jul 10, 2019
Closed
@lizan lizan mentioned this pull request Jul 11, 2019
Merged
lizan added a commit that referenced this pull request Jul 12, 2019
@lizan
coverage: ignore generated file precisely (#7551)
1a2a235 
Description:
Regression in #6866. k8-dbg/bin is excluded to ignore generated files but virtual_includes are there too.

Risk Level: Low
Testing: CI 🙏
Docs Changes:
Release Notes:
Fixes #7474

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htuch htuch htuch approved these changes

@mattklein123 mattklein123 Awaiting requested review from mattklein123

Assignees

@htuch htuch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lizan @dio @htuch @hlopko